Repository navigation
Fix what the second CI round found - #22
Merged
Merged
Conversation
* **Two phpstan.neon files had a duplicated key.** Merging the branch with
main put a second `ignoreErrors` / `reportUnmatchedIgnoredErrors` under
`parameters:` -- git merges that cleanly because neither side touched the
other's lines, and NEON then refuses to load the file at all. PHPStan exits
with its usage banner rather than an analysis, so the job fails without ever
naming a rule. error-pages and package-scaffolder are folded back to one
declaration each.
* **Orphaned `@var list<string>` docblocks.** Deleting the `$commandAliases`
properties left their docblocks sitting above the next method, where
PHPStan reports `PHPDoc tag @var above a method has no effect`. Five in
product-demo-mode.
* **Pint drift, resolved at the version CI actually installs.** CI resolves
laravel/pint 1.32.1; a long-lived local vendor/ had 1.30.5, and the two
disagree about `binary_operator_spaces`. Checking against the old one is the
same false green as checking against the wrong config -- so this ran 1.32.1.
* **console:** PHPStan proves the `property_exists($this, 'commandAliases')`
guard false, because it only sees the subclasses inside src/ and none of
them declare it. The property belongs to the CONSUMING command -- a trait
and a using class cannot both declare it with different defaults -- so the
guard is exactly right and the finding is scoped away with that reason.
Benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix what the second CI round found
Two phpstan.neon files had a duplicated key. Merging the branch with
main put a second
ignoreErrors/reportUnmatchedIgnoredErrorsunderparameters:-- git merges that cleanly because neither side touched theother's lines, and NEON then refuses to load the file at all. PHPStan exits
with its usage banner rather than an analysis, so the job fails without ever
naming a rule. error-pages and package-scaffolder are folded back to one
declaration each.
Orphaned
@var list<string>docblocks. Deleting the$commandAliasesproperties left their docblocks sitting above the next method, where
PHPStan reports
PHPDoc tag @var above a method has no effect. Five inproduct-demo-mode.
Pint drift, resolved at the version CI actually installs. CI resolves
laravel/pint 1.32.1; a long-lived local vendor/ had 1.30.5, and the two
disagree about
binary_operator_spaces. Checking against the old one is thesame false green as checking against the wrong config -- so this ran 1.32.1.
console: PHPStan proves the
property_exists($this, 'commandAliases')guard false, because it only sees the subclasses inside src/ and none of
them declare it. The property belongs to the CONSUMING command -- a trait
and a using class cannot both declare it with different defaults -- so the
guard is exactly right and the finding is scoped away with that reason.