Repository navigation
Adopt the shared laranail Pint config - #3
Merged
Merged
Conversation
`composer pint` runs `vendor/bin/laranail-pint`, which passes package-tools' **shared** `pint.json` rather than any local one. Until the stale composer cache was busted, that binary was missing and the step died with `Could not open input file` — so this check had never actually run here. This is the reformat it asks for. **Cosmetic, and verified as such.** Every file already declared `strict_types`, so the config's `declare_strict_types` rule adds nothing. The full suite was run before and after and returns the **identical** result — that equality was the gate: any repo whose test count or assertion count moved was reverted rather than committed, and three were. Part of the org-wide adoption of the shared config. See `laranail/package-tools` `pint.json`.
The workflow ran `vendor/bin/pint --test` while `composer pint` runs `vendor/bin/laranail-pint --test`. Those are not the same check: these repos ship no pint.json at all, so the bare invocation used Pint's OWN defaults, not the shared laranail config the composer script declares. That is the false green laranail-pint exists to prevent - its own docblock records forty-nine packages in exactly that state, all reporting clean. It is also why the reformat in this PR made the step go red: the code now matches the shared config, and the workflow was still checking against defaults. Same binary as `composer pint` now, so CI and the composer script agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
composer pintrunsvendor/bin/laranail-pint, which passes package-tools'shared
pint.jsonrather than any local one. Until the stale composer cachewas busted, that binary was missing and the step died with
Could not open input file— so this check had never actually run here.This is the reformat it asks for.
Cosmetic, and verified as such. Every file already declared
strict_types,so the config's
declare_strict_typesrule adds nothing. The full suite was runbefore and after and returns the identical result — that equality was the
gate: any repo whose test count or assertion count moved was reverted rather
than committed, and three were.
Part of the org-wide adoption of the shared config. See
laranail/package-toolspint.json.