Repository navigation
Write example credentials as placeholders - #23
Merged
Merged
Conversation
A literal password in a URL's userinfo is flagged by secret scanners whatever its value. The test now builds the URL at runtime with sprintf, and docs use template syntax, so the asserted behaviour is unchanged and nothing reads as a leaked credential.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hygiene fixes from the 2026-10-13 audit, one commit per concern.
Example credentials. Dummy values shaped like real secrets (a vendor key prefix, or a password in a URL's userinfo) are rewritten at source: docs use
<placeholder>syntax and tests build credential URLs at runtime, so test behaviour is unchanged. Found by agent-kitsecret_scan.py detect(all findings classified dummy, none real);secret_scan.py check --ref HEADnow reports 0 dummy.Verified locally with actionlint (no new findings) before pushing.