Repository navigation
Base the install command on package-tools' InstallCommand - #18
Merged
Merged
Conversation
Decision 6: the install command subclasses laranail/package-tools' InstallCommand and keeps laranail/console's display API through its two traits, so neither package depends on the other. A contract test pins the name, description, visibility, definition, output and exit code against the old base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies decision 6 (the pattern merged in laranail/captcha#24).
InstallCommandnow extendsSimtabi\Laranail\Package\Tools\Commands\InstallCommandand uses laranail/console'sInteractsWithConsoleServicesandInteractsWithConsoleWritertraits. No new dependency direction.hidden: falseso the command stays listed, restores the original description, and boots console support eagerly.packageRegistered(), since the new base takes thePackage.tests/Feature/InstallCommandContractTest.phppins name, aliases, description, visibility, definition, output lines and exit code. Behaviour assertions passed on the old base; the inheritance assertion failed there and passes now.Local: Pest 99 passed, PHPStan clean, Pint (shared laranail config) clean, Rector dry-run clean.