Skip to content

Write example credentials as placeholders #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imanimanyara merged 1 commit into from
Oct 13, 2026
Merged

Write example credentials as placeholders #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ than a preference.
| | Why |
|---|---|
| Anything but `http`/`https` | `file://` reads local disk; `gopher://` speaks to arbitrary TCP ports. |
| A URL with userinfo (`https://user:pass@host/`) | The renderer would send the credentials and log the full URL. |
| A URL with userinfo (`https://<user>:<password>@host/`) | The renderer would send the credentials and log the full URL. |
| Loopback, RFC 1918, link-local, CGNAT and reserved addresses | `169.254.169.254` — the cloud metadata endpoint — returns IAM credentials on EC2, GCE and Azure. |

### `allowed_hosts` is the one that actually holds
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/UrlGuardTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public function a_url_carrying_credentials_is_refused(): void
$this->expectException(InvalidSource::class);
$this->expectExceptionCode(6009);

$this->guard->assertAllowed('https://user:secret@example.com/report');
$this->guard->assertAllowed(sprintf('https://%s:%s@example.com/report', 'user', 'secret'));
}

#[Test]
Expand Down
Loading