Repository navigation
Base the install command on package-tools' InstallCommand - #19
Merged
Merged
Conversation
laranail::pdf.install now extends package-tools' install base and keeps console's display API through its two traits, so neither package depends on the other. A contract test pins the name, option, description, listing visibility, output and exit codes against the old base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
laranail::pdf.installnow extends laranail/package-tools'InstallCommandand keeps laranail/console's display API by using itsInteractsWithConsoleServicesandInteractsWithConsoleWritertraits, matching laranail/captcha#24. No new dependency direction.hidden: falseso the command stays listed, restores its own description, and boots console support.packageRegistered()because the new base takes thePackagein its constructor.handle()takesDriverRegistryas an optional parameter, still injected by the container, because the base declareshandle(): intand a required parameter would not be a compatible override.Contract
tests/Feature/InstallCommandContractTest.phppins name, aliases, description,isHidden(), the--forceoption and its value mode, no arguments, key output lines and exit code 0. Written first: the behaviour assertions passed on the old base and the inheritance assertion failed.Local checks