Repository navigation
Check the chained resolver's answer and use the public router - #22
Merged
Merged
Conversation
RouteNameFallback passed the previous missing-route resolver's answer through unchecked, so a non-string answer was a TypeError inside route() under strict_types; it now reads as not resolved. The scoped-route check also read the URL generator's protected route collection through a bound closure, although Router::has() answers the same question publicly. register() takes the router as an optional second argument, so the old single-argument call keeps working.
CI's Rector run rejected the two tests added in this branch for using inline fully qualified UrlGenerator and RouteCollection. Import them, as Rector's import-names rule and the shared Pint ordering require.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RouteNameFallback passed the previous missing-route resolver's answer
through unchecked, so a non-string answer was a TypeError inside route()
under strict_types; it now reads as not resolved. The scoped-route check
also read the URL generator's protected route collection through a bound
closure, although Router::has() answers the same question publicly.
register() takes the router as an optional second argument, so the old
single-argument call keeps working.