Repository navigation
Make install work and read the config where it is registered - #13
Merged
Merged
Conversation
Two defects stopped the package working at all. The shipped config named the hook command Simtabi\GitCommitChecker\Commands\PreCommitHookCommand, a namespace the package never had, so install aborted with "Class [...] not found". And both commands read the bare git-commit-checker key while the provider registers laranail.git-commit-checker. On an unpublished install, install iterated no hooks and the hook always reported itself disabled. The config now names the real class. Both commands read through one helper that prefers laranail.git-commit-checker and still honours a config published to the old bare path, as a deprecated fallback. The publish tag now writes config/laranail/git-commit-checker.php. Tests cover the class existing, the hook running when enabled and skipping when disabled at the registered key, and the legacy override. The class and enabled tests failed before the fix. The README gains its Quick start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two defects stopped the package working at all. The shipped config named
the hook command Simtabi\GitCommitChecker\Commands\PreCommitHookCommand, a
namespace the package never had, so install aborted with "Class [...] not
found". And both commands read the bare git-commit-checker key while the
provider registers laranail.git-commit-checker. On an unpublished install,
install iterated no hooks and the hook always reported itself disabled.
The config now names the real class. Both commands read through one helper
that prefers laranail.git-commit-checker and still honours a config
published to the old bare path, as a deprecated fallback. The publish tag
now writes config/laranail/git-commit-checker.php.
Tests cover the class existing, the hook running when enabled and skipping
when disabled at the registered key, and the legacy override. The class and
enabled tests failed before the fix. The README gains its Quick start.