Repository navigation
Warn once per deprecated route name and limiter - #19
Merged
Merged
Conversation
The bare env-kit.* route-name fallback logged a warning on every resolution, so a page with N links logged N lines per request, and the bare env-kit limiter logged on every throttled request, which never stops on an Octane or queue worker. Both now log once per name for the life of the booted application.
laranail/env-kit now reads its configuration only at laranail.env-kit.*; the old bare env-kit.* reads were the defect that left its shipped config inert. This suite had worked around it by setting the bare keys, so against a fresh resolve every override (temp .env path, schema, allowlist, hidden keys, value limit) was ignored and 13 tests ran on defaults. main fails the same way. No runtime code read the bare keys; tests and one docs line move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bare env-kit.* route-name fallback logged a warning on every
resolution, so a page with N links logged N lines per request, and the bare
env-kit limiter logged on every throttled request, which never stops on an
Octane or queue worker. Both now log once per name for the life of the
booted application.