Repository navigation
Document the trait a :: command name needs; fix a dead anchor - #72
Merged
Merged
Conversation
Extending the base Command alone does not allow laranail::<slug>.<cmd> names: the base does not compose SupportsNamespacedNames, so Symfony's validateName() throws in the constructor, which for a provider-registered command means at boot. The docs implied the base was enough; they now say both are required, with a working example and a vendor-scoped alias in place of a bare make:crud. NamespacedNameRequirementTest pins the three combinations. getting-started linked a README anchor that never existed; the output styles now live on that page, and DocumentedNamesTest checks every intra-repo fragment link resolves. The README named the community inbox as the vulnerability address; SECURITY.md and the org rule say security@simtabi.com.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extending the base Command alone does not allow laranail::.
names: the base does not compose SupportsNamespacedNames, so Symfony's
validateName() throws in the constructor, which for a provider-registered
command means at boot. The docs implied the base was enough; they now say
both are required, with a working example and a vendor-scoped alias in
place of a bare make:crud. NamespacedNameRequirementTest pins the three
combinations.
getting-started linked a README anchor that never existed; the output
styles now live on that page, and DocumentedNamesTest checks every
intra-repo fragment link resolves. The README named the community inbox
as the vulnerability address; SECURITY.md and the org rule say
security@simtabi.com.