Repository navigation
Read the assets config where the provider registers it - #13
Merged
Merged
Conversation
The provider merges the defaults into laranail.assets, but Assets read the bare `assets` key, which nothing populates on a fresh install. Resolving Assets therefore threw "Trying to access array offset on null", and every documented call failed unless the config had been published. Separately, addStyles() merged into the script list, so a stylesheet rendered as a <script> tag. Assets now reads laranail.assets. A config already published to the old bare config/assets.php is still honoured, as a deprecated fallback, so nobody the package worked for sees a change. The publish tag now writes config/laranail/assets.php, and the default is merged in register() so it exists before other providers boot. Each test was seen failing with its fix reverted: the config-key revert fails 3 of 6, and the addStyles revert fails 1. The README gains the Quick start that depended on this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provider merges the defaults into laranail.assets, but Assets read the
<script> tag. Assets now reads laranail.assets. A config already published to the old bare config/assets.php is still honoured, as a deprecated fallback, so nobody the package worked for sees a change. The publish tag now writes config/laranail/assets.php, and the default is merged in register() so it exists before other providers boot. Each test was seen failing with its fix reverted: the config-key revert fails 3 of 6, and the addStyles revert fails 1. The README gains the Quick start that depended on this fix.bare
assetskey, which nothing populates on a fresh install. ResolvingAssets therefore threw "Trying to access array offset on null", and every
documented call failed unless the config had been published. Separately,
addStyles() merged into the script list, so a stylesheet rendered as a