Skip to content

feat: add shell plugin v0.0.1#2431

Closed
yanyifei-coder wants to merge 4 commits into
langgenius:mainfrom
yanyifei-coder:add-shell-plugin
Closed

feat: add shell plugin v0.0.1#2431
yanyifei-coder wants to merge 4 commits into
langgenius:mainfrom
yanyifei-coder:add-shell-plugin

Conversation

@yanyifei-coder
Copy link
Copy Markdown

Shell Command Execution Plugin

Description

A Shell command execution tool plugin for Dify that allows AI agents to execute shell commands with configurable timeout and security controls.

Features

  • Execute shell commands with real-time output
  • Configurable command timeout (default 10s, max 300s)
  • Security controls: blocked commands (rm -rf /, mkfs, dd, etc.)
  • Working directory support
  • Environment variable configuration
  • Standard output and error output capture

Plugin Info

  • Author: yanyifei-coder
  • Version: 0.0.1
  • Type: Tool Plugin

Files

  • yanyifei-coder/shell/shell-0.0.1.difypkg

Add dify-shell plugin - a Shell command execution tool for Dify.
Supports executing shell commands with timeout and security controls.
Copy link
Copy Markdown
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Request Changes

Decision: Request changes

Failed Checks

Check Status Detail Required action
Project structure ❌ Fail Missing files: README.md. Present: manifest.yaml, PRIVACY.md. _assets/: yes. Include all required files in the package: manifest.yaml, README.md, PRIVACY.md, and _assets/.
README language ❌ Fail README.md not found in plugin package. Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme
dify_plugin version ❌ Fail dify_plugin must be installed and >= 0.5.0, but it was not found. Use dify_plugin >= 0.5.0 in the packaged plugin environment.

Full Check Results

Check Status Detail Required action
PR content language ✅ Pass PR title/body CJK ratio=0.0% (zh=0, en=481, ignored_zh=0, allowed_zh<=0) None.
Project structure ❌ Fail Missing files: README.md. Present: manifest.yaml, PRIVACY.md. _assets/: yes. Include all required files in the package: manifest.yaml, README.md, PRIVACY.md, and _assets/.
Manifest author ✅ Pass author is valid. None.
Icon validation ✅ Pass icon exists: _assets/icon.svg None.
Version check ✅ Pass version 0.0.1 is available. None.
README language ❌ Fail README.md not found in plugin package. Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme
PRIVACY.md ✅ Pass PRIVACY.md exists and is non-empty. None.
Dependency install ✅ Pass requirements.txt not found; skipped. None.
dify_plugin version ❌ Fail dify_plugin must be installed and >= 0.5.0, but it was not found. Use dify_plugin >= 0.5.0 in the packaged plugin environment.
Install test ✅ Pass requirements.txt not found; skipped. None.
Packaging test ✅ Pass packaging check passed. None.

Next steps

Please address these issues and push an update.

yanyifei_wz added 2 commits May 19, 2026 18:56
- Added README.md (English) and README.zh-CN.md (Chinese)
- _assets/icon.svg already included
- Repackaged shell-0.0.1.difypkg with required files
- Add README.md (English) in plugin root directory
- Add readme/README_zh_Hans.md (Chinese) per multilingual README spec
- Rename privacy.md to PRIVACY.md
- Update pyproject.toml: dify-plugin -> dify_plugin>=0.5.0
- Remove __pycache__ from package
- Repackaged shell-0.0.1.difypkg
Copy link
Copy Markdown
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Request Changes

Decision: Request changes

Failed Checks

Check Status Detail Required action
dify_plugin version ❌ Fail dify_plugin must be installed and >= 0.5.0, but it was not found. Use dify_plugin >= 0.5.0 in the packaged plugin environment.

Full Check Results

Check Status Detail Required action
PR content language ✅ Pass PR title/body CJK ratio=0.0% (zh=0, en=481, ignored_zh=0, allowed_zh<=0) None.
Project structure ✅ Pass All expected files present: manifest.yaml, README.md, PRIVACY.md. _assets/: yes. None.
Manifest author ✅ Pass author is valid. None.
Icon validation ✅ Pass icon exists: _assets/icon.svg None.
Version check ✅ Pass version 0.0.1 is available. None.
README language ✅ Pass README.md CJK ratio=0.0% (zh=0, en=1104, allowed_zh<=0) None.
PRIVACY.md ✅ Pass PRIVACY.md exists and is non-empty. None.
Dependency install ✅ Pass requirements.txt not found; skipped. None.
dify_plugin version ❌ Fail dify_plugin must be installed and >= 0.5.0, but it was not found. Use dify_plugin >= 0.5.0 in the packaged plugin environment.
Install test ✅ Pass requirements.txt not found; skipped. None.
Packaging test ✅ Pass packaging check passed. None.

Next steps

  • dify_plugin version: Use dify_plugin >= 0.5.0 in the packaged plugin environment.

Please address these issues and push an update.

@crazywoola crazywoola dismissed their stale review May 27, 2026 10:31

Stale review on an older commit; clearing before a fresh review.

Copy link
Copy Markdown
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Decision: Approve

Local Check Results

Check Status Detail
PR content language ✅ Pass PR title/body CJK ratio=0.0% (zh=0, en=481, ignored_zh=0, allowed_zh<=0)
Project structure ✅ Pass All expected files present: manifest.yaml, README.md, PRIVACY.md. _assets/: yes.
Manifest author ✅ Pass author is valid.
Icon validation ✅ Pass icon exists: _assets/icon.svg
Version check ✅ Pass version 0.0.1 is available.
README language ✅ Pass README.md CJK ratio=0.0% (zh=0, en=1104, allowed_zh<=0)
PRIVACY.md ✅ Pass PRIVACY.md exists and is non-empty.
Dependency install ✅ Pass requirements installed successfully.
dify_plugin version ✅ Pass dify_plugin version 0.9.0 satisfies >= 0.5.0.
Install test ✅ Pass plugin install test passed.
Packaging test ✅ Pass packaging check passed.

@crazywoola
Copy link
Copy Markdown
Member

Thank you for your contribution. We need to close this PR for now because the required CI checks are failing.

For security and compatibility reasons, please make sure dify_plugin is installed and updated to version >= 0.9.0. After updating the PR and confirming the checks pass, you are welcome to reopen it or submit a new PR for review.

Thanks again for helping improve the Dify plugin ecosystem.

@crazywoola crazywoola closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants