Dutch group feedback: submit-button wording, MB-CDI link in new tab, no-location background variant - #654
Open
mcfrank wants to merge 1 commit into
Open
Dutch group feedback: submit-button wording, MB-CDI link in new tab, no-location background variant#654mcfrank wants to merge 1 commit into
mcfrank wants to merge 1 commit into
Conversation
…location background variant
Three small, independent fixes requested by the Dutch group (EU deployment):
1. Completion button "Click to complete the study" -> "Submit your responses"
(administration_summary.html, cat_forms/cat_completed.html). The old wording
read like the end of the study; participants who continue in Qualtrics were
closing the tab. Only fr and ja had translated the old string; other locales
(incl. nl) already showed English, so a makemessages pass + fr/ja
re-translation is the only follow-up.
2. "For more information about the MB-CDI" link now opens in a new tab
(target=_blank rel=noopener) on the study intro and background-info pages,
so participants don't navigate away from the questionnaire and lose it.
3. New background-questionnaire option Dutch_CAT_no_location.json: a copy of
Dutch_CAT.json without the country ("Land") + postcode fields (postcode is
sensitive personal data, especially under GDPR on their EU server). Enable it
by loading dutch_cat_no_location_demographic.json or adding a Demographic
record (name + path) in the admin, then pick it when creating a study.
Two other feedback items are already fixed in the modernization stack, not here:
the CAT per-question page reload (fixed by the in-browser jsCat engine) and the
"Zeg ba" -> "Zeg bal" instruction-image typo (current images are already
correct). The Dutch server just needs to update.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small, independent fixes from the Dutch group's feedback (they run their own EU deployment). Branched off
master, so it's independent of the modernization stack and can merge on its own.1. Completion button wording
"Click to complete the study" → "Submit your responses" (
administration_summary.html,cat_forms/cat_completed.html). Their participants continue the study in Qualtrics afterward, and the old wording read like the end — some were closing the tab.Translation note: only fr and ja had translated the old string; every other locale (including nl) had an empty
msgstrand already showed the English text, so the Dutch group sees the new wording immediately. Amakemessagespass + fr/ja re-translation is the only follow-up; I didn't hand-edit those translations.2. MB-CDI link opens in a new tab
Added
target="_blank" rel="noopener"to the "For more information about the MB-CDI" link on the study-intro (study_group.html) andbackground_info.htmlpages. The latter is exactly the scenario they described — a participant mid-questionnaire clicks the link and loses their place.3. Background questionnaire without Land/Postcode
New
Dutch_CAT_no_location.json— a copy ofDutch_CAT.jsonwith thecountry(Land) +zip_code(postcode) block removed. Postcode is sensitive personal data, especially under GDPR on an EU server.To enable it: load
researcher_UI/fixtures/dutch_cat_no_location_demographic.json(manage.py loaddata dutch_cat_no_location_demographic), or add aDemographicrecord in the admin (nameDutch_CAT_no_location.json, path/form_data/background_info/Dutch_CAT_no_location.json) — same as their existingDutch_CAToption. It then appears as a selectable questionnaire when creating a study, leaving the original intact.Two feedback items are already fixed elsewhere (not in this PR)
CAT_ENGINE=browseron deploy.Zeg "bal"/Say "ball"(verified the base, CAT, and WS variants). Their EU server just has an older image.Both resolve when the Dutch server updates to the current version.
Verification
Trivial text/attribute edits + validated JSON. Full participant-flow browser rendering (these pages need a live administration) was disproportionate; the two changes are
{% trans %}string swaps and HTML attribute additions, which can't introduce template errors, and both new JSON files parse.🤖 Generated with Claude Code