Repository navigation
fix: Do not always run the exit trap and return with 1 even if everything is fine - #110
Merged
Merged
Conversation
✅ Deploy Preview for setup-lando ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for get-lando canceled.
|
Member
|
looking at this again i think the issue is |
florianPat
force-pushed
the
exit-not-always-1
branch
from
January 3, 2026 12:49
5748fe1 to
05055d6
Compare
Contributor
Author
|
That makes sense, I changed that and amended :) |
AaronFeledy
approved these changes
Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The script returns with exit code 1 even if the "exit 0" in the end is run.
This is due to the trap that always triggers...
I now just reset the trap after the user interaction.
Is that the right approach?
Note
Prevents unintended non-zero exits caused by an overbroad trap in interactive flow.
wait_for_userto trap onlySIGINT(Ctrl-C), removingEXITso the cleanup handler no longer runs on normal script completionWritten by Cursor Bugbot for commit 0c422f0. This will update automatically on new commits. Configure here.