Code outside a named function is never scanned

[jbrown9513]

methodsOf in src/analysis.js scans only declarations whose name is not <anonymous>. An exported arrow named by its assignment has name: <anonymous> and qualified_name: module.exports.validateInput and is skipped (#125). Anonymous callbacks (#123), a module whose export is an expression (#129) and a file whose functions come from a macro invocation (#130) have no named declaration and get no reading at all.

Scan by qualified_name when an assignment names an anonymous function. Give each file one unit for its top-level code so a file with no named function is still read.

[marko-niskala]

An anonymous function passed as an argument to a call whose result is assigned is also skipped, and the assignment-name fallback above would not reach it, because the analyzer gives it qualified_name: <anonymous> rather than the binding's name:

type Handler = (req: Request) => Promise<Response>;

function withAuth(handler: Handler): Handler {
  return async (req) => handler(req);
}

export async function named(req: Request): Promise<Response> {
  return new Response(await req.text());
}

export const wrapped = withAuth(async (req) => {
  return new Response(await req.text());
});

export const bare = async (req: Request): Promise<Response> => {
  return new Response(await req.text());
};

On ec3b021, analyzeSource returns withAuth, withAuth.<anonymous>, named, <anonymous> (line 11) and bare; perch scan reads three methods, withAuth, named and bare, and never the body of wrapped. Route handlers are commonly declared this way behind an auth or error-handling wrapper, so such a codebase gets its helpers scanned and none of its handlers.

Naming the argument after the binding its enclosing call is assigned to (wrapped) would cover it.