ci: allow manual dispatch of post-release homebrew and docs jobs - #1842
Merged
Conversation
The update-homebrew-formula and update-cli-docs workflows declare a
workflow_dispatch trigger, but their job-level guard only passed for
workflow_run events:
if: ${{ github.event.workflow_run.conclusion == 'success' }}
On a manual dispatch github.event.workflow_run is absent, so the guard
evaluated false and the job was skipped, making manual runs a no-op.
Also accept workflow_dispatch so these jobs can be re-run by hand (e.g.
to recover a release whose post-release automation failed).
lokesh-vadlamudi
had a problem deploying
to
cli-docs
June 23, 2026 22:21 — with
GitHub Actions
Failure
lokesh-vadlamudi
marked this pull request as ready for review
June 23, 2026 22:25
lokesh-vadlamudi
enabled auto-merge (squash)
June 23, 2026 22:25
wsli-1
approved these changes
Jun 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both
Update Homebrew FormulaandUpdate CLI Docsdeclare aworkflow_dispatchtrigger, but their job-level guard only passed forworkflow_runevents:On a manual dispatch there is no
github.event.workflow_run, so the expression evaluates to false and the job is skipped — making manual runs a no-op (observed: dispatched runs complete in ~3s with conclusionskipped).This widens the guard to also accept manual dispatch:
Why
These are the post-release automation jobs whose failures were just fixed in #1841. They only auto-run after a successful
Release, so when one fails (or, as with v2.14.1, was failing before the fix landed) there was no way to re-run it by hand to catch a release up. Allowingworkflow_dispatchmakes them recoverable on demand.Normal release behavior is unchanged — the
workflow_runpath still requires a successful Release.