Skip to content

ci: allow manual dispatch of post-release homebrew and docs jobs - #1842

Merged
lokesh-vadlamudi merged 2 commits into
mainfrom
lvadlamudi/dispatchable-release-jobs
Jun 23, 2026
Merged

ci: allow manual dispatch of post-release homebrew and docs jobs#1842
lokesh-vadlamudi merged 2 commits into
mainfrom
lvadlamudi/dispatchable-release-jobs

Conversation

@lokesh-vadlamudi

Copy link
Copy Markdown
Collaborator

Summary

Both Update Homebrew Formula and Update CLI Docs declare a workflow_dispatch trigger, but their job-level guard only passed for workflow_run events:

if: ${{ github.event.workflow_run.conclusion == 'success' }}

On a manual dispatch there is no github.event.workflow_run, so the expression evaluates to false and the job is skipped — making manual runs a no-op (observed: dispatched runs complete in ~3s with conclusion skipped).

This widens the guard to also accept manual dispatch:

if: ${{ github.event_name == 'workflow_dispatch' || github.event.workflow_run.conclusion == 'success' }}

Why

These are the post-release automation jobs whose failures were just fixed in #1841. They only auto-run after a successful Release, so when one fails (or, as with v2.14.1, was failing before the fix landed) there was no way to re-run it by hand to catch a release up. Allowing workflow_dispatch makes them recoverable on demand.

Normal release behavior is unchanged — the workflow_run path still requires a successful Release.

The update-homebrew-formula and update-cli-docs workflows declare a
workflow_dispatch trigger, but their job-level guard only passed for
workflow_run events:

  if: ${{ github.event.workflow_run.conclusion == 'success' }}

On a manual dispatch github.event.workflow_run is absent, so the guard
evaluated false and the job was skipped, making manual runs a no-op.
Also accept workflow_dispatch so these jobs can be re-run by hand (e.g.
to recover a release whose post-release automation failed).
@lokesh-vadlamudi lokesh-vadlamudi self-assigned this Jun 23, 2026
@lokesh-vadlamudi
lokesh-vadlamudi marked this pull request as ready for review June 23, 2026 22:25
@lokesh-vadlamudi
lokesh-vadlamudi requested a review from a team as a code owner June 23, 2026 22:25
@lokesh-vadlamudi
lokesh-vadlamudi enabled auto-merge (squash) June 23, 2026 22:25
@lokesh-vadlamudi
lokesh-vadlamudi requested a review from wsli-1 June 23, 2026 22:25
@lokesh-vadlamudi
lokesh-vadlamudi merged commit a781666 into main Jun 23, 2026
12 of 13 checks passed
@lokesh-vadlamudi
lokesh-vadlamudi deleted the lvadlamudi/dispatchable-release-jobs branch June 23, 2026 22:43
@lacework-releng lacework-releng mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants