Conversation
Author
|
I'm working on Mercury, and would like to add support to it in wl2k-go. |
Member
|
Thanks for the PR, and for your work on Mercury. I’ve taken a look through the implementation and I have a few structural and administrative concerns we should discuss:
Let me know your thoughts on how best to proceed. |
Member
|
Related to la5nta/pat#546 and la5nta/pat#523 |
Author
|
There is already a discussion about it. Nice. I'll read it all, and whatever solution is decided, I can contribute and test (separate or together with Vara's one). |
Add a transport driver for Rhizomatica's Mercury HF modem (https://github.com/Rhizomatica/mercury), an open-source OFDM modem that exposes a VARA-compatible TCP TNC interface: a CR-terminated ASCII command/status port and a raw binary data port on the following port number. The driver is adapted from Pat-Vara (https://github.com/n8jja/Pat-Vara, MIT licensed, Copyright (c) 2021 Jeremy Bush / N8JJA), with the VARA-only behaviour removed: Mercury never sends CWID or the WINLINK/P2P SESSION distinction and does not compress. Mercury and VARA are separate implementations expected to diverge over time, so this lives in its own package rather than extending the vara package. The original N8JJA copyright notice is preserved in every adapted file alongside the Rhizomatica notice. Implements Dialer, ContextDialer, net.Conn, net.Listener, BusyChannelChecker, Flusher, TxBuffer and PTTController injection. Also mark "mercury" as a scheme that rejects digipeater paths in transport.ParseURL. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UPX7axfwktuMidLrX8x78k
Author
|
I renamed to mercury-only. But I did not know about the other activities, so I'm fine to abandon this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a transport driver for Rhizomatica's Mercury HF modem, an open-source OFDM modem that exposes a VARA-compatible TCP TNC interface: a CR-terminated ASCII command/status port and a raw binary data port on the following port number.
The driver is adapted from Pat-Vara (MIT licensed, Copyright (c) 2021 Jeremy Bush / N8JJA), with the VARA-only behaviour removed — Mercury never sends
CWIDor theWINLINK/P2P SESSIONdistinction, and does not compress. Following the discussion in la5nta/pat#523 and la5nta/pat#546, Mercury and VARA are treated as separate implementations expected to diverge over time, so this lives in its owntransport/mercurypackage rather than extending thevarapackage. The original N8JJA copyright notice is preserved in every adapted file alongside the Rhizomatica notice, and the package doc credits the origin.Implements
Dialer,ContextDialer,net.Conn,net.Listener,BusyChannelChecker,Flusher,TxBufferandPTTControllerinjection.Also marks
mercuryas a scheme that rejects digipeater paths intransport.ParseURL.Application-level wiring in Pat (config, listener registration, connect/listen dispatch) is out of scope here and is tracked separately (la5nta/pat#545).
Related: la5nta/pat#523, la5nta/pat#546
🤖 Generated with Claude Code
https://claude.ai/code/session_01UPX7axfwktuMidLrX8x78k