fix: CI survives force-pushed tags with bad before SHA - #23
Merged
Conversation
When a tag is force-pushed, github.event.before is the old tag object SHA which no longer exists in the repo. git diff on a bad object exits 128 and kills the Detect Changes step. Fall back to listing all files when the before SHA fails git cat-file -e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git cat-file -echeck before usinggithub.event.beforeas a diff basebeforeSHA is the old tag object which no longer exists in the repo, causinggit diffto fail with exit 128git ls-tree -r --name-only HEAD(list all files) in that case, same as the new-branch pathTest plan