Repository navigation
feat: add approved TTV generation and editorial selection - #31
Conversation
Record the primary H3 Max profile and its HTTP 403 account-balance blocker separately from passing HTTP/RQ and secondary Veo acceptance. Include measured render results and repeatable provider-neutral commands. Validation: fresh 696-test unittest, ruff and mypy gate at implementation head; real HTTP/RQ two-job import/render flow; real Veo render and verify; 22-case producer/consumer parity; docs links and git diff --check.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13d62a1c65
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Record the real H3 Max provider chain passing unchanged consumer import, selection, rendering and verification with normal audio normalization. Distinguish measured source and preview properties and preserve raw billing units separately from unknown USD costs. Validation: shipped CLI handoff/render/media-verify acceptance, explicit approved provider/model/shot/prompt comparison, ffprobe and audio levels, documentation links and git diff --check. No source changes.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7820d39c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f902afcc6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Reject duplicate variant IDs, missing required references, and substituted reviewed keyframes. Trace recorded keyframe and image preparation inputs and scope billing by result, scene, and attempt. Preserve portrait reframe and transcript options in immutable EDL revisions. Connect reviewed motion-graphics storyboards, visual evidence, and existing provider spending permission to the TTV generation workflow. Validation: 736 tests, Ruff, mypy, shared contract parity, and a fresh producer-to-consumer pilot rendering and verifying both edit revisions.
kumanday
changed the title
1 participant
Summary
Add
media-generatedso project-local agent harnesses can exchange approved TTV generation documents, import verified assets, select takes, and compile ordinary EDLs with immutable provenance. Connect the reviewed motion-graphics storyboard to generated footage and preserve the current media workflows from main.Changes
reframeand transcript options with grading, overlays, and subtitles; hash editorial files. Scope billing observations by result, scene, and attempt.Evidence
Test output
Verification
New regressions cover duplicate variant IDs, required reference omission and substitution, exact reviewed keyframes, scoped attempt IDs, and actual portrait rendering. Eleven shared contract cases agree with TTV, with identical schema/manifest/fixture bytes. A fresh TTV offline handoff imported, selected, rendered, and verified both the original edit and a middle-scene replacement while preserving outer takes and enforcing stale-continuity acceptance. Earlier live provider evidence is documented in
docs/generated-media.md.Checklist
Type of change
Breaking changes
None to the existing renderer, verifier, narration, or FCPXML interfaces. Invalid generation approvals and selections fail before rendering.
Related issues
Companion producer: trilogy-group/ttv-pipeline#21
Additional notes
Selected generated clips need matching aspect ratios and frame rates for the existing concat renderer. Creative review metadata is maintained by the agent; the CLI validates the generation contract and approval lineage. Live GCS transfer remains unverified, and no new paid provider calls were made for this update.