Skip to content

test(agent): split server exec tests by concern - #23225

Merged
kubestellar-hive[bot] merged 1 commit into
kubestellar:mainfrom
be-student:codex/23218-split-server-exec-tests
Sep 8, 2026
Merged

test(agent): split server exec tests by concern#23225
kubestellar-hive[bot] merged 1 commit into
kubestellar:mainfrom
be-student:codex/23218-split-server-exec-tests

Conversation

@be-student

Copy link
Copy Markdown
Contributor

📌 Fixes

Fixes #23218

📝 Summary of Changes

  • Split the 1,176-line server exec test file by message, WebSocket I/O, resize queue, and handler concerns.
  • Keep the WebSocket fixture in a shared test helper and preserve all 37 tests.

Changes Made

  • Refactored test organization without changing production behavior
  • Kept imports local to each split file
  • Verified the complete focused and package test suites

Checklist

  • I used Codex to generate/review this code
  • I have reviewed the project's contribution guidelines
  • No card or demo-data behavior is changed
  • Existing unit coverage is preserved
  • I tested the changes locally
  • All commits are signed with DCO

Screenshots or Logs

  • go test ./pkg/agent/ -run 'AgentExec|AgentWS|AgentTerminal|HandleExec|ExecConstants' -count=1
  • go test ./pkg/agent/ -count=1
  • gofmt and git diff --check

👀 Reviewer Notes

The test-function inventory is unchanged: 37 before and after the split.

Preserve all 37 existing tests while separating message, websocket I/O, resize queue, and handler coverage. Keep the websocket fixture in a shared test helper.

Fixes kubestellar#23218

Signed-off-by: eunwoo song <presentsong@naver.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Sep 6, 2026
@netlify

netlify Bot commented Sep 6, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 5fbbefc
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a9d28434005a400082b2d9a

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

👋 Welcome to the KubeStellar community! 💖

Thanks and congrats 🎉 for opening your first PR here! We're excited to have you contributing.

Before merge, please ensure:

  • DCO Sign-off — All commits signed with git commit -s (DCO)
  • PR Title — Starts with an emoji: ✨ feature | 🐛 bug fix | 📖 docs | 🌱 infra/tests | ⚠️ breaking

📬 If you're using KubeStellar in your organization, please add your name to our Adopters list. 🙏 It really helps the project gain momentum and credibility — a small contribution back with a big impact.

Resources:

A maintainer will review your PR soon. Hope you have a great time here!

🌟 ~~~~~~~~~~ 🌟

📬 If you like KubeStellar, please ⭐ star ⭐ our repo to support it!

🙏 It really helps the project gain momentum and credibility — a small contribution back with a big impact.

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 6, 2026
@kubestellar-hive kubestellar-hive Bot added agent/scanner Filed by the scanner agent hive/hosted-kubestellar-console-4vkt Hive instance hosted-kubestellar-console-4vkt labels Sep 8, 2026
@kubestellar-hive
kubestellar-hive Bot merged commit bedfe5d into kubestellar:main Sep 8, 2026
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent/scanner Filed by the scanner agent dco-signoff: yes Indicates the PR's author has signed the DCO. hive/hosted-kubestellar-console-4vkt Hive instance hosted-kubestellar-console-4vkt size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] Split pkg/agent/server_exec_test.go (1176 lines, 37 tests) into focused test files

1 participant