fix(lifelong): avoid indexing beyond dataset splits - #980
Open
ali-raza-7 wants to merge 2 commits into
Open
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ali-raza-7 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
ValidationI verified the fix locally with the following checks:
The fix updates the lifelong-learning loops to use |
Author
|
/assign @jaypume |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the lifelong learning paradigm to iterate over the actual number of dataset splits returned by
split_dataset()instead of relying on theroundsvalue.Changes
range(rounds + 1)withrange(len(dataset_files)).roundswithlen(dataset_files).Validation
python3 -m py_compile core/testcasecontroller/algorithm/paradigm/lifelong_learning/lifelong_learning.py— PASSgit diff --check— PASStimes=2— PASSlifelong_learning.py.Rationale
The dataset splitting logic determines the actual number of dataset files returned by
split_dataset(). Usingroundsfor indexing can result in accessing a dataset split that does not exist.Iterating over
len(dataset_files)keeps the lifelong-learning loops aligned with the dataset splits actually returned by the dataset splitter.