fix: handle digit-bearing model architectures in M3L Signed-off-by: nitbig <nitishkr13245@gmail.com> - #968
Open
nitbig wants to merge 2 commits into
Open
fix: handle digit-bearing model architectures in M3L Signed-off-by: nitbig <nitishkr13245@gmail.com>#968nitbig wants to merge 2 commits into
nitbig wants to merge 2 commits into
Conversation
Refactor model loading and prediction methods for clarity and error handling. Update regex for architecture extraction and improve code formatting.
…itbig <nitishkr13245@gmail.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nitbig The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR improves model architecture extraction in the M3L ReID model loader.
The previous regular expression only supported architecture names containing alphabetic characters, which caused supported models such as
resnet50andresnet101to fail during model loading.The updated expression supports architecture names containing letters, numbers, underscores and hyphens. It also explicitly supports both
.pthand.pth.tarcheckpoint formats.The model loader now raises a clear
ValueErrorwhen the architecture cannot be inferred from the checkpoint filename instead of failing with an unclearAttributeError.The existing
addmm_update is also retained to use the current PyTorch keyword based API.Testing:
Verified architecture extraction for
IBNMeta,resnet50and other digit based architecture names.Verified support for
.pthand.pth.tarcheckpoint filenames.Verified that invalid checkpoint filenames produce a clear
ValueError.Which issue(s) this PR fixes:
Fixes #445