Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

apps.v1.deployment constructor match pods across deployments #152

Description

@redbaron

current defaults are pretty dangerous ,as they going to match pods across deployments:

new(name='', replicas=1, containers='', podLabels={ app: 'name' }):: apiVersion + kind + 
...
self.mixin.spec.template.metadata.withLabels(podLabels) + 
...

should be something like:

new(name='', replicas=1, containers='', podLabels=null):: apiVersion + kind + 
...
self.mixin.spec.template.metadata.withLabels(if podLabels != null podLabels else {app: name}) +
...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions