Skip to content

feat(creator): expand visual presets and template curation - #338

Closed
dingle-kb wants to merge 8 commits into
developfrom
feat-lele-template
Closed

dingle-kb wants to merge 8 commits into
developfrom
feat-lele-template

Conversation

@dingle-kb

Copy link
Copy Markdown
Collaborator

Summary

  • Refine Creator template browsing, detail presentation, filters, and image-generation flow already developed on this branch.
  • Import 15 supported visual presets (12 image, 3 video) from dingle-kb/awesome-visual-prompts with localized editable prompts and source-case previews.
  • Apply local operator ordering, featured, and archive settings while keeping the admin application outside this repository.

Verification

  • pnpm templates:ci: 114 presets validated and compiled.
  • Web and Daemon typechecks passed; targeted Web tests 35/35, Daemon tests 65/65, local admin tests 5/5.
  • New preset card, detail, preview, and job-creation flows passed in desktop and mobile Chromium (4/4).

Before merge

  • Third-party example media and prompts are not automatically MIT-licensed by the source repository; verify redistribution and commercial-use rights.
  • Source examples are visual references, not verified outputs of OpenCreator. No paid provider-generation or packaged Desktop validation was performed.
  • 21 additional source cases remain excluded because they need multiple reference images, longer duration, or multi-stage workflows. See the import record under docs/.

@wulien wulien left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I reviewed the actual incremental changes against the current master, the template import record, and the checks for head b54e0383011b75e40825c93a7a5c830239b715e9.

The feature adds 15 visual presets (12 image and 3 video), operator-controlled template ordering/featured/visibility settings, and generation-flow/provider changes. The fact that the PR targets develop is not, by itself, a reason to reject it; the integration target is master.

Blocking issues

1. Integration conflicts with current master

Decision: BLOCKED_BY_CONFLICTS.

A non-mutating git merge-tree --write-tree simulation against master bfbf59a8375ae8c11decb3ebd4ea5e5a7be741de reports content conflicts in:

  • apps/daemon/test/integration/creator-api.test.ts
  • apps/web/src/features/conversation/CreatorDashboard.tsx
  • apps/web/src/styles/app.css

Impact:
The current head cannot be integrated into the supported branch without conflict resolution. GitHub's MERGEABLE result is against develop, not master.

Required change:
Update this branch against the latest master, resolve the conflicts while preserving the already-integrated dashboard behavior and tests, and rerun the affected checks. Retargeting the GitHub base alone is not required and does not resolve the code conflicts.

2. The new published source media have an explicitly unresolved distribution gate

docs/awesome-visual-prompts-模板接入记录.md explicitly states that third-party media/prompts are not covered automatically by the source repository's MIT license and that the distribution permission review has not been completed. The added presets are marked published and include copied cover.jpg, preview.jpg, and example.mp4 assets that enter the distributed catalog.

Impact:
The PR itself identifies an outstanding prerequisite for distributing these newly imported assets. Attribution and the “not a verified output” notice do not establish that this prerequisite has been met.

Required change:
Document the applicable distribution permissions/provenance for the newly imported media and prompts, or replace/remove the unresolved assets and any content that cannot be distributed. Keep the distinction between source examples and verified OpenCreator outputs.

Verification required

  • Current-head compile passes, but unit and web-parity fail. The unit job stops at dependency audit before running tests, so it is not evidence of failing unit assertions and I am not attributing that existing dependency failure to these changes.
  • The current web-parity run reports 27 failures, including missing Creator diagnostic/Workspace controls. After resolving the master conflicts, provide passing current-head checks or concrete evidence separating pre-existing failures from this PR's dashboard changes; do not treat the existing red run as parity evidence.
  • Run targeted preset compiler/registry, image executor/provider, and dashboard ordering/featured/visibility tests plus Web/Daemon typechecks. The provider-specific asynchronous image-task path also needs protocol/smoke evidence, rather than only mocked responses.
  • Mark the PR ready for review only after these prerequisites are satisfied. It is currently a draft.

No maintainer-side conflict resolution, merge commit, master update, or packaged Desktop verification was performed.

wulien pushed a commit that referenced this pull request Oct 1, 2026
Selectively import 15 reviewed visual presets from b54e038. Exclude the six functional shortcuts and all provider, executor, compiler and frontend changes. Keep the presets as drafts pending output and redistribution-rights verification.
wulien pushed a commit that referenced this pull request Oct 1, 2026
Integrate the reviewed template-only correction, not the original PR head. No supplier-specific runtime or shared cover behavior changes are included.
@wulien wulien closed this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants