Conversation
Import 15 supported visual presets with localized prompts and source previews. Apply local template order, featured, and visibility settings; cover catalog and client flows with focused tests.
wulien
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I reviewed the actual incremental changes against the current master, the template import record, and the checks for head b54e0383011b75e40825c93a7a5c830239b715e9.
The feature adds 15 visual presets (12 image and 3 video), operator-controlled template ordering/featured/visibility settings, and generation-flow/provider changes. The fact that the PR targets develop is not, by itself, a reason to reject it; the integration target is master.
Blocking issues
1. Integration conflicts with current master
Decision: BLOCKED_BY_CONFLICTS.
A non-mutating git merge-tree --write-tree simulation against master bfbf59a8375ae8c11decb3ebd4ea5e5a7be741de reports content conflicts in:
apps/daemon/test/integration/creator-api.test.tsapps/web/src/features/conversation/CreatorDashboard.tsxapps/web/src/styles/app.css
Impact:
The current head cannot be integrated into the supported branch without conflict resolution. GitHub's MERGEABLE result is against develop, not master.
Required change:
Update this branch against the latest master, resolve the conflicts while preserving the already-integrated dashboard behavior and tests, and rerun the affected checks. Retargeting the GitHub base alone is not required and does not resolve the code conflicts.
2. The new published source media have an explicitly unresolved distribution gate
docs/awesome-visual-prompts-模板接入记录.md explicitly states that third-party media/prompts are not covered automatically by the source repository's MIT license and that the distribution permission review has not been completed. The added presets are marked published and include copied cover.jpg, preview.jpg, and example.mp4 assets that enter the distributed catalog.
Impact:
The PR itself identifies an outstanding prerequisite for distributing these newly imported assets. Attribution and the “not a verified output” notice do not establish that this prerequisite has been met.
Required change:
Document the applicable distribution permissions/provenance for the newly imported media and prompts, or replace/remove the unresolved assets and any content that cannot be distributed. Keep the distinction between source examples and verified OpenCreator outputs.
Verification required
- Current-head
compilepasses, butunitandweb-parityfail. Theunitjob stops at dependency audit before running tests, so it is not evidence of failing unit assertions and I am not attributing that existing dependency failure to these changes. - The current
web-parityrun reports 27 failures, including missing Creator diagnostic/Workspace controls. After resolving the master conflicts, provide passing current-head checks or concrete evidence separating pre-existing failures from this PR's dashboard changes; do not treat the existing red run as parity evidence. - Run targeted preset compiler/registry, image executor/provider, and dashboard ordering/featured/visibility tests plus Web/Daemon typechecks. The provider-specific asynchronous image-task path also needs protocol/smoke evidence, rather than only mocked responses.
- Mark the PR ready for review only after these prerequisites are satisfied. It is currently a draft.
No maintainer-side conflict resolution, merge commit, master update, or packaged Desktop verification was performed.
Selectively import 15 reviewed visual presets from b54e038. Exclude the six functional shortcuts and all provider, executor, compiler and frontend changes. Keep the presets as drafts pending output and redistribution-rights verification.
Integrate the reviewed template-only correction, not the original PR head. No supplier-specific runtime or shared cover behavior changes are included.
Summary
Verification
pnpm templates:ci: 114 presets validated and compiled.Before merge
docs/.