-
Notifications
You must be signed in to change notification settings - Fork 1
docs: update CLI and helm reference for v2.39.1 #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,8 +26,8 @@ exponential backoff between retries. Once the results are available they are att | |
| 2. Providing the Sonar project key and either the revision or the pull-request ID of the scan (plus the SonarQube server URL if relevant). | ||
| For branch scans: if running the Kosli CLI in some CI/CD pipeline, the revision is defaulted to the commit SHA. If you are running the command locally, | ||
| or have overriden the revision in SonarQube via parameters to the Sonar scanner, you can provide the correct revision using the `--sonar-revision` flag. | ||
| If the scan ran on a branch other than the project's main branch in SonarQube, also provide the branch name using the `--sonar-branch` flag: | ||
| SonarQube searches only the main branch unless it is told otherwise, so without it the scan cannot be found. | ||
| If the scan ran on a branch other than the project's main branch in SonarQube, also provide the branch name using the `--sonar-branch` flag. | ||
| SonarQube only searches the project's main branch unless told otherwise, so without this flag the scan cannot be found. | ||
|
Comment on lines
+29
to
+30
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion — the rewrite here is an improvement (splitting the run-on into two sentences and dropping the dangling colon). Two pre-existing issues in the same paragraph that are worth fixing upstream while this text is being touched:
Generated file — fix in |
||
| For pull request scans: provide the pull-request ID using the `--pull-request` flag instead of the revision. | ||
| Kosli then finds the scan results for the specified project key and revision or pull-request ID. | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improvement — this rewritten paragraph is the only substantive prose change in the PR, and a few things read ambiguously for a reference page:
for one you may not view—may notis ambiguous between permission and possibility.one you do not have permission to viewis unambiguous.--jira-base-url(documented at line 93) helps readers connect the prose to the flag.scripts/and theLive docssection ofCLAUDE.md), so any wording fix has to land in the CLI's long-description inkosli-dev/cli— not here. Non-blocking for this release PR.