Skip to content

update bulk discount #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sami-alajrami merged 2 commits into from
Aug 27, 2026
Merged

update bulk discount #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c17d6d9
update bulk discount
sami-alajrami Aug 27, 2026
daaf163
fix tests
sami-alajrami Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/kosli/demo/orders/OrderPricer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public final class OrderPricer {
static final BigDecimal UNIT_PRICE = new BigDecimal("10.00");
static final BigDecimal EXPEDITED_FEE = new BigDecimal("7.85");
static final int BULK_THRESHOLD = 10;
static final BigDecimal BULK_DISCOUNT = new BigDecimal("0.05");
static final BigDecimal BULK_DISCOUNT = new BigDecimal("0.06");

private OrderPricer() {
}
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/kosli/demo/orders/OrderPricerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ void goldTierDiscount() {
}

@Test
@DisplayName("bulk orders stack an extra 5% on top of the tier discount")
@DisplayName("bulk orders stack an extra 6% on top of the tier discount")
void bulkDiscountStacks() {
OrderPricer.Quote quote = OrderPricer.quote(12, "GOLD", false);

assertThat(quote.subtotal()).isEqualByComparingTo("120.00");
assertThat(quote.total()).isEqualByComparingTo("96.00");
assertThat(quote.total()).isEqualByComparingTo("94.80");
}

@Test
Expand Down