Require peer-review in the env policy, and make integration-tests a control - #44
Merged
Merged
Conversation
…ontrol secure-development.yml (staging + production) now names peer-review-decision explicitly via the schema's for_control field on a decision-type rule, rather than relying only on implicit trail-compliance coverage - confirmed live that for_control matches a trail-level decision attestation. Also names sbom. integration-tests moves off the last remaining "jq rules on the attestation type decide compliance" pattern and becomes a control, the same shape as peer-review: kosli/policies/integration-tests.rego judges the report, the verdict is recorded as a trail-level decision attestation instead of being bound to the orders-api artifact, and production-readiness.yml requires it via for_control. The now-unused custom:integration-test type and its schema are removed.
JonJagger
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secure-development.yml(staging + production) now namespeer-review-decisionexplicitly via the schema'sfor_controlfield on adecision-type rule, instead of relying only on implicittrail-compliancecoverage. Also namessbomexplicitly.integration-testsmoves off the last remaining "jq rules on the attestation type decide compliance" pattern and becomes a control, the same shape aspeer-review:kosli/policies/integration-tests.regojudges the report (same three conditions the old jq rules checked).report-integration-test-result.ymlnow evaluates the report and records the verdict as a trail-leveldecisionattestation viakosli attest decision --control integration-tests, instead of binding it to theorders-apifingerprint.production-readiness.ymlrequires it viafor_control: integration-tests.custom:integration-testattestation type and its schema are removed;bootstrap_kosli.shgains anintegration-testscontrol block alongsidepeer-review's.Test plan
peer-review,integration-tests) and the updated policies apply cleanlymain, confirmpeer-review-decisionand the newintegration-tests-decisionland on the trail, and thatpublish-gate/release-gatestill evaluate correctly against the updatedsecure-development.yml/production-readiness.ymlfor_controlactually satisfies the policy against a trail-level decision attestation in a live assert (already confirmed by the customer per conversation, but worth re-checking on this specific run)