Skip to content

fix : rename misleading cache_hits to cached_items in ml_recommender#1334

Open
tmdeveloper007 wants to merge 1 commit into
komalharshita:mainfrom
tmdeveloper007:#1329
Open

fix : rename misleading cache_hits to cached_items in ml_recommender#1334
tmdeveloper007 wants to merge 1 commit into
komalharshita:mainfrom
tmdeveloper007:#1329

Conversation

@tmdeveloper007

Copy link
Copy Markdown

Summary of What Has Been Done

Fixed the misleading cache_hits field in src/utils/ml_recommender.py get_model_metrics method. The field was returning len(self.cache) (the current number of cached items) instead of actual cache hit counts.

Changes Made

  • Renamed cache_hits to cached_items in get_model_metrics to accurately reflect what the metric measures
  • Removed the now-unused _count_cache_hits helper method

Impact it Made

  • Ensures API consumers understand the metric represents cached items, not hit counts
  • Removes dead code (_count_cache_hits method is no longer needed)
  • Provides accurate naming that matches the actual data returned

Note

Please assign this PR to the tmdeveloper007 account.

@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown

@tmdeveloper007 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant