Repository navigation
feat(ui): stage dropped files on the Convert tab - #5
Merged
Merged
Conversation
A drop while Convert is visible used to fall through to the library import path, which needs an iPod and starts writing immediately. Convert now takes the paths and only lists them: format, bitrate and destination are still unset at that moment, so nothing runs until Convert Files is pressed. Claude-Session: https://claude.ai/code/session_016BSACqVKky8go5gyYk41xk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dropping audio on the window while the Convert tab is open used to fall through to the library import path — it required a connected iPod and started writing to it right away. The drop now lands in Convert's queue and only lists the files; format, bitrate and destination are still the user's to set, so nothing is converted until Convert Files is pressed.
Changes
App.tsxroutes thedropevent by visible tab through aviewRef, handing paths to Convert instead ofimportFileswhen Convert is up. Logged asdrop.staged.ConvertViewtakesdroppedPaths/onDropStaged/isDropTarget, stages the paths via the samestage()the Add button uses, and refuses with a message while a job is running (the backend reads the queue).Also carries
docs: rewrite the readme for users (#1), whichdevdid not have yet.Test plan
npx tsc --noEmit— clean.npm test— 125 passing.https://claude.ai/code/session_016BSACqVKky8go5gyYk41xk