Skip to content

feat(ui): stage dropped files on the Convert tab - #5

Merged
kolebayev merged 2 commits into
devfrom
kolebayev/fix-convert-area
Aug 21, 2026
Merged

kolebayev merged 2 commits into
devfrom
kolebayev/fix-convert-area

Conversation

@kolebayev

Copy link
Copy Markdown
Owner

Summary

Dropping audio on the window while the Convert tab is open used to fall through to the library import path — it required a connected iPod and started writing to it right away. The drop now lands in Convert's queue and only lists the files; format, bitrate and destination are still the user's to set, so nothing is converted until Convert Files is pressed.

Changes

  • App.tsx routes the drop event by visible tab through a viewRef, handing paths to Convert instead of importFiles when Convert is up. Logged as drop.staged.
  • The path list is built once and shared by both log lines; the empty-drop guard moved ahead of it.
  • ConvertView takes droppedPaths / onDropStaged / isDropTarget, stages the paths via the same stage() the Add button uses, and refuses with a message while a job is running (the backend reads the queue).
  • The queue draws the same dashed drop frame the track list does, and the empty state mentions dropping.

Also carries docs: rewrite the readme for users (#1), which dev did not have yet.

Test plan

  • npx tsc --noEmit — clean.
  • npm test — 125 passing.
  • Manually: drop files with Convert open → queue fills, nothing runs; drop with Library open and an iPod connected → import as before; drop with Library open and no iPod → same "Connect an iPod" error; drop mid-conversion → error, queue unchanged.

https://claude.ai/code/session_016BSACqVKky8go5gyYk41xk

A drop while Convert is visible used to fall through to the library
import path, which needs an iPod and starts writing immediately.
Convert now takes the paths and only lists them: format, bitrate and
destination are still unset at that moment, so nothing runs until
Convert Files is pressed.

Claude-Session: https://claude.ai/code/session_016BSACqVKky8go5gyYk41xk
@kolebayev
kolebayev merged commit 5e3cafc into dev Aug 21, 2026
4 checks passed
@kolebayev
kolebayev deleted the kolebayev/fix-convert-area branch August 21, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant