Repository navigation
fix(ui): stage bulk cover art until apply - #4
Merged
Merged
Conversation
Picking a cover in the bulk panel wrote it to every selected track immediately, out of step with the other fields and with no way back from a mis-click. It is now a draft like any other field: the panel shows the staged file name, offers Clear, and the single Apply stamps fields and artwork together. Claude-Session: https://claude.ai/code/session_01TdJdhEhGTJHScRWETLqEYA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the bulk edit panel, picking a cover applied it to every selected track the moment the file dialog closed — out of step with the other fields, which wait for Apply, and with no way back from a mis-click. Cover art is now a draft like any other field, so one Apply covers the whole edit.
Changes
BulkEditPanelholds the picked path inpendingArtinstead of firingonSetArtworkfrom the file dialog.Apply N Changes to M Tracks, and it stays disabled when nothing is staged.Choose Another…, and aClearbutton drops the staged cover.onSetArtworknow returns a promise;App.tsxreturns itsrun(...)chain so Apply can await it and holdApplying…until the art lands.Test plan
npm run typecheck— clean.npm test— 125 tests across 8 files pass.