Repository navigation
fix(ui): pin the stats header above the scroller - #2
Merged
Merged
Conversation
The title and Copy Snapshot lived inside the scrolling pane, so they slid away as soon as the cover wall moved.
kolebayev
added a commit
that referenced
this pull request
Aug 21, 2026
feat(ui): sort the track list by column heading StatsView conflicted with the pinned header from #2: both branches replaced the pane's `flex-1` root because the tab wrapper is a plain block. The header split already roots at `flex h-full flex-col` and moved the scroller inside, so that structure wins and only the reasoning from this branch's comment is kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Stats tab's header — the listening-time title, its blurb and the Copy
Snapshot button — sat inside the scrolling pane, so it slid away with the
cover wall. It now sits above the scroller and stays put.
Changes
StatsViewsplits into a fixed header (shrink-0 border-b bg-background)and a scrolling body holding the cover wall, facts strip, treemap and
rankings.
flex h-full flex-col;h-fullrather thanflex-1because the tab wrapper in
App.tsxis a plain block, the same reasonEmptyStateuses it.pt-10→pt-8now that the header is out of it.Test plan
npm run typecheck— clean.was not opened in the running app.
Note: this branch forked from
main, which is ahead ofdev, so the PR alsocarries
docs: rewrite the readme for users (#1).