test effect: remove extra effects from definition time#55
Open
timbertson wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for #53. I think this makes more sense.
effectful-testno longer requires the effect at definition time, it just produces a test case that requires the effect. That matchestest, which doesn't requireiobut produces atest<io>.It was always a little confusing that you could theoretically use one
asynchandler at definition time but a different one at execution time.And now
groupdoesn't need to assumeio, it just adopts whatever test types are used in its body.I originally thought it might be important to allow additional effects in
groupbodies, and maybe we'll need to support that later. But I don't know of a use case yet, so let's not guess.