test(e2e): give each case of a multi-case test its own test - #14
Merged
Merged
Conversation
Five previews (throwing, resolved, shadowing, crashing, unpainted) were one test, as were the three --capture screen cases and the two --enter cases. A failure stopped the cases after it, and lastRun could read the run of an earlier case. Each case is now a test with its own copy of the example; the annotation cases move to annotations_test.dart. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some e2e tests covered independent cases in sequence on one project: five previews (throwing, resolved, shadowing, crashing, unpainted), the three
--capture screencases (scale, menu, pushed page), and the two--entercases (order, label).A failing expectation stopped the cases after it, and when a shot wrote no run,
lastRunreturned the run of an earlier case.Each case is now its own test with its own copy of the example (
flutter pub geton the copy takes about half a second).The annotation cases (throwing MultiPreview, static const and sealed, shadowing) move to
annotations_test.dart; the crash and the unpainted shell stay inerrors_test.dart.The assertions are unchanged.
🤖 Generated with Claude Code