fix: support ESLint 10 by using context.filename with getFilename() fallback - #195
Closed
watarukino wants to merge 1 commit into
Closed
fix: support ESLint 10 by using context.filename with getFilename() fallback#195watarukino wants to merge 1 commit into
watarukino wants to merge 1 commit into
Conversation
…allback ESLint 10 removed the deprecated context.getFilename() method, so the rule crashes at execution time on ESLint 10: TypeError: context.getFilename is not a function context.filename has been available since ESLint 8.40. Use it when present and fall back to context.getFilename() to keep compatibility with older ESLint versions.
Author
|
duplicate #193 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ESLint 10 removed the long-deprecated
context.getFilename()method. As a result,strict-dependenciescrashes at rule execution time on ESLint 10:Fix
Use
context.filename(available since ESLint 8.40) when present, falling back tocontext.getFilename()for older ESLint versions:This is the only usage of a removed ESLint 10 context API in the plugin (checked against
getFilename/getSourceCode/getScope/getAncestors/getPhysicalFilename/getCwd/parserOptions), so this one-line change restores ESLint 10 compatibility.Testing
yarn test: 34/34 passedpnpm patchand would love to drop the patch once this lands 🙏)