frontend: default to MP4 output with automatic format detection - #181
Open
nschimme wants to merge 1 commit into
Open
frontend: default to MP4 output with automatic format detection#181nschimme wants to merge 1 commit into
nschimme wants to merge 1 commit into
Conversation
| Overwrite existing output file | ||
| .SH MP4 SPECIFIC OPTIONS | ||
| .TP | ||
| .BR -w |
Collaborator
There was a problem hiding this comment.
Maybe keep this option as a noop dummy for people having this hard code in their scripts?
Contributor
Author
There was a problem hiding this comment.
I thought about adding a dummy flag, but I'm worried about silent failures for users not passing -w and suddenly being surprised by .m4a over an .aac extension. Fail-fast behavior with a breaking change feels safer here so users know they need to update their scripts. What do you think?
Update the frontend and GUI to default to MP4 container output while
enabling automatic output format detection based on file extension.
* CLI Options: Replace '-w' (create MP4) with '-a' to explicitly request
ADTS stream output.
* Format Detection: Implement detect_container_mp4() to infer MP4 or ADTS
output based on filename extensions (.aac/.adts vs .m4a/.mp4/.m4b).
Default stdout ("-") and unknown extensions appropriately.
* Overwrite Protection: Add checks in the encoding session and GUI dialog
to prevent accidentally overwriting existing output files unless
explicitly configured.
* Documentation: Update man page (faac.1) and HTML documentation (faac.html)
to reflect updated CLI flags and automatic format selection.
nschimme
force-pushed
the
frontend-mp4-default
branch
from
August 30, 2026 12:08
17c1da7 to
edb0a84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes MP4 the default output format with extension-based auto-detection (
.m4a/.mp4-> MP4,.aac-> ADTS), adds explicit-afor ADTS, and adds overwrite protection.Why
.m4afiles. MP4 containers provide native seeking, duration indexing, rich metadata (tags/art), and seamless HTML5/OS playback, whereas raw.aacADTS streams often break seeking or fail to play in modern software..aac), the MP4 container stores encoder delay/padding metadata required for sample-exact gapless playback.ffmpegbehavior) without requiring legacy flags like-w.Key Changes
-) to ADTS.-wwith-a/--adtsto force ADTS stream output when needed.encode_engine.cand confirmation dialog tomaingui.c.faac.1man page andfaac.html.