feat: make pstack and pi-subagents coexist - #2
Open
satyam-mishra-pce wants to merge 4 commits into
Open
Conversation
… conflicts Pi hard-fails startup when two loaded extensions register a tool with the same name (the conflict is recorded as an error diagnostic, and main exits on any error diagnostic). The generic name "subagent" collides with other packages in the ecosystem, e.g. npm:pi-subagents, making pi-pstack unusable alongside them. Rename the registered tool to the namespaced pstack_subagent, matching the existing pstack_* naming convention (pstack_todo, pstack_sessions, pstack_config), and update all references in the poteto-mode system prompt, README, and skills.
|
I don't think this guy cares about the repo anymore...don't want to maintain my own fork :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pi cannot start when
pi-pstackandpi-subagentsare both enabled because both extensions register a tool namedsubagent. Pstack's bundled agents are also invisible topi-subagentsworkflows even though both packages can be useful together.This supersedes the tool-rename fix in #1 and carries that fix together with the package integration work.
Fix
pstack_subagent, preserving its pstack-specificrole,tasks, andchainbehavior.poteto-agentandcomment-sickothrough both Pi andpi-subagentspackage metadata.pstack_subagentversussubagent.The two packages remain independently installable. This does not make
pi-pstackdepend onpi-subagents, so standalone pstack users keep the existing native implementation. When both are enabled, users get pstack's role-aware delegation andpi-subagents' background, mission, worktree, and resumable workflows in the same Pi session.Validation
npm testgit diff --checkPI_CODING_AGENT_DIR. Startup reached model authentication without reporting a tool conflict.