Repository navigation
Update loop condition in maglev.go - #6
Merged
Merged
Conversation
This works as-is, but I think the outer `for {}` makes the loop look more dangerous than it actually is. Since the real goal is to keep filling entries until `n == m.m`, using `for n < m.m` would make the termination condition explicit and easier to reason about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works as-is, but I think the outer
for {}makes the loop look more dangerous than it actually is. Since the real goal is to keep filling entries untiln == m.m, usingfor n < m.mwould make the termination condition explicit and easier to reason about.