fix: remove unused modules - #45
Merged
Merged
Conversation
These were only used in one place each in the Kivra codebase which have now been removed.
There was a problem hiding this comment.
Pull request overview
This PR removes two Erlang helper modules (s2_math and s2_maps) that are no longer used, and updates the README manifest accordingly.
Changes:
- Delete
src/s2_math.erl(ceiling/floor helpers + eunit tests). - Delete
src/s2_maps.erl(nested dictionary helper). - Remove
s2_maps.erlfrom the README manifest.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/s2_math.erl | Removed unused math helper module (and its tests). |
| src/s2_maps.erl | Removed unused nested-dictionary helper module. |
| README.md | Updated manifest to no longer list the removed module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zigge-zagge
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were only used in one place
each in the Kivra codebase which
have now been removed.