no-release: [PE-7420] allow for merge queues - #107
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Three moderate workflow issues must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates GitHub Actions CI to support merge queues and test current pull-request and queued states before merging.
Changes:
- Adds
pull_requestandmerge_grouptriggers. - Restricts push-triggered CI to
main. - Adjusts checkout and Renovate lockfile push behavior.
File summaries
| File | Summary | Findings |
|---|---|---|
.github/workflows/ci.yml |
Adds merge-queue CI support and updates checkout/push logic. | Three moderate issues: deterministic head SHA checkout (3 votes), preserving required check context (2 votes), and restricting lockfile pushes to same-repository PRs (1 vote). |
Review details
Suppressed comments (1)
.github/workflows/ci.yml:67
- This condition also allows fork-originated PRs with a
renovate/...head branch into the push logic. TheirGITHUB_TOKENis read-only andoriginis the base repository, so thegit pushfails and marks the PR check unsuccessful; restrict the lock-file push to PRs whose head repository is the current repository.
- if: github.event_name == 'pull_request'
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kivra-pauoli
force-pushed
the
feature/merge-group
branch
from
September 17, 2026 16:21
e1ea560 to
166bb71
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The workflow exposes write-capable credentials and weakens base-branch validation.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (1)
.github/workflows/ci.yml:31
- This changes
pull_requestruns from GitHub's synthetic merge ref to the PR head commit. As a result, the check can pass even when the PR no longer builds against the current base branch; the combined-state check only runs after the PR enters a merge queue, so ordinary PR validation and any consumers of this check lose merge-result coverage. Keep the CI checkout on the base repository's merge ref, and use a separate head-branch checkout/push path for the Renovate lock update if that behavior is required.
repository: ${{ github.event.pull_request.head.repo.full_name || github.repository }}
ref: ${{ github.event.pull_request.head.sha || github.ref }}
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Increase confidence in our releases by preventing integration bugs.
Description
Currently, concurrent pull requests are often merged out of sequence. This can introduce undetected issues because the changes are tested in isolation against an older base branch rather than the combined latest state.
To prevent this, we are enabling merge queues. This ensures every PR is tested against the most up-to-date state before it is merged. This is particularly helpful for increasing confidence in PRs that modify state-dependent external services.