no-release: [PE-7420] allow for merge queues - #36
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The workflow exposes write-capable execution to merge-group code and may invalidate required checks.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Enables GitHub merge queue validation so pull requests are tested against the latest queued state.
Changes:
- Adds the
merge_group.checks_requestedtrigger. - Renames the CI workflow.
File summaries
| File | Summary |
|---|---|
.github/workflows/ci.yml |
Enables merge queue checks and updates workflow metadata; review findings identify workflow permission and required-check compatibility issues. |
Review details
Suppressed comments (1)
.github/workflows/ci.yml:2
- Changing the workflow name changes the check-suite/check display identity for this workflow. If the existing
cicheck is required by branch protection or the merge queue, that required check will no longer match and merges can remain blocked (or the queue can stop recognizing the required check). This trigger-only change should keep the existing workflow name, or update the repository's required-check configuration in the same change.
name: Continuous Integration
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kivra-pauoli
force-pushed
the
feature/merge-group
branch
from
September 17, 2026 16:21
91a5ab2 to
ea3f967
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
Merge-group CI must avoid exposing write-capable repository credentials to queued code.
Review details
Suppressed comments (1)
.github/workflows/ci.yml:16
- Adding
merge_groupcauses the queued PR's checked-out code to run with this workflow'scontents: writetoken. A merge-group run is not a forkpull_requestrun, so the token is not automatically downgraded; code executed bymake ci(including dependency/build hooks) can use the persisted checkout credentials to push to the repository. Keep merge-group validation read-only by separating the Renovate/release write operations into trusted jobs/workflows and granting this CI job onlycontents: readbefore enabling this trigger.
merge_group:
types:
- checks_requested
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Increase confidence in our releases by preventing integration bugs.
Description
Currently, concurrent pull requests are often merged out of sequence. This can introduce undetected issues because the changes are tested in isolation against an older base branch rather than the combined latest state.
To prevent this, we are enabling merge queues. This ensures every PR is tested against the most up-to-date state before it is merged. This is particularly helpful for increasing confidence in PRs that modify state-dependent external services.