[BUGFIX] Set default height for PageView map container - #2151
Merged
sebastian-meyer merged 2 commits intoSep 18, 2026
Merged
Conversation
The map container (#tx-dlf-map) normally gets its height from the
theme CSS. The extension itself ships no stylesheet for it, so on an
installation without a theme the container is 0 pixels tall and
OpenLayers renders nothing at all ("No map visible because the map
container's width or height are 0").
Apply a fallback height (57 em, as used by the UB Mannheim theme) in
dlfViewer when the computed container height is 0. Explicit theme CSS
is unaffected, since the fallback only applies when no height is set.
Assisted-by: OpenCode / qwen3.8-27b-thinking (Alibaba Cloud)
Signed-off-by: Stefan Weil <sw@weilnetz.de>
sebastian-meyer
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The map container (#tx-dlf-map) normally gets its height from the theme CSS. The extension itself ships no stylesheet for it, so on an installation without a theme the container is 0 pixels tall and OpenLayers renders nothing at all ("No map visible because the map container's width or height are 0").
Apply a fallback height (57 em, as used by the UB Mannheim theme) in dlfViewer when the computed container height is 0. Explicit theme CSS is unaffected, since the fallback only applies when no height is set.
Assisted-by: OpenCode / qwen3.8-27b-thinking (Alibaba Cloud)