Fix #42: tip jar sheet abort in UIKit's focus engine (DEBUG/--uitest shim) + FR-1100-08 regression guard - #44
Merged
Merged
Conversation
…gs (FR-1100-08) Hermetic XCUITest via the --uitest-store/--uitest-entitlements seams; landscape is load-bearing (the issue #42 focus-engine abort only fires there — portrait would green the test without proving anything). Red before the fix on both the iPadOS 26.0 and iOS 18.6 simulators. Claude-Session: https://claude.ai/code/session_01XWbnBdWdcjnCH5smD6X1Ai
#42) Presenting the tip jar sheet over a landscape iPad Form aborts in -[_UIFocusContainerGuideFallbackItemsContainer initWithParentEnvironment:] -- an unfixed internal UIKit bug (Apple r.154431813, DTS-confirmed, no view-level workaround) that fires only while a hardware keyboard is connected, i.e. the simulator default. Every view-side hypothesis was tried and disproven by running it: .sheet(item:), collapsing the stacked sheets, NavigationStack, presentationDetents, and removing the focus/accessibility modifiers. Since the keyboardless production frame never executes this path, the fix is a test-infrastructure shim, not a shipping-code change: FocusEngineUITestWorkaround (DEBUG-only, --uitest-gated) no-ops UIFocusSystem.updateFocusIfNeeded, which XCUITest -- being accessibility-driven -- never needs. Absent from Release. Gates green on the iPad Pro 11-inch (M4) / iPadOS 26.0 sim, hardware keyboard connected: TipJarPresentationUITests 1/1, PurchaseGateUITests 6/6, SettingsUITests 4/4, warm multi-class combo 11/11, German sweep 74-76 3/3 (the three previously uncapturable screens; their German reviewed clean). Trap documented in docs/testing.md. Fixes #42 Claude-Session: https://claude.ai/code/session_01XWbnBdWdcjnCH5smD6X1Ai
kipp-ing
added a commit
that referenced
this pull request
Sep 13, 2026
Fix #42: tip jar sheet abort in UIKit's focus engine (DEBUG/--uitest shim) + FR-1100-08 regression guard
kipp-ing
added a commit
that referenced
this pull request
Sep 13, 2026
Fix #42: tip jar sheet abort in UIKit's focus engine (DEBUG/--uitest shim) + FR-1100-08 regression guard
kipp-ing
added a commit
that referenced
this pull request
Sep 26, 2026
Fix #42: tip jar sheet abort in UIKit's focus engine (DEBUG/--uitest shim) + FR-1100-08 regression guard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dual-agent TDD flow on #42.
Diagnosis (test agent): the SIGABRT in
_UIFocusContainerGuideFallbackItemsContaineris an unfixed internal UIKit bug (Apple r.154431813, DTS-confirmed) triggered by presenting the tip jar sheet over a landscape iPad Form while a hardware keyboard is connected — the simulator default. Reproduces identically on iPadOS 26.0 and iOS 18.6, so it is not a 26-simulator artifact. Portrait, or a keyboardless sim, never crashes. The keyboardless wall-mounted production frame never runs this path.Fix (implementation agent): every view-level arrangement was tried and disproven by running it (
.sheet(item:), collapsing the three stacked sheets,NavigationStack,presentationDetents, focus/accessibility modifiers). The landed fix is therefore a test-infrastructure shim, not a shipping-code change:FocusEngineUITestWorkaroundinOwnFrameApp.swift— DEBUG-only,--uitest-gated, no-opsUIFocusSystem.updateFocusIfNeeded(XCUITest drives the UI via the accessibility API and never needs the focus engine). Absent from the Release binary.SlideshowSettingsView/TipJarViewstay pristine.Judgment call, flagged for visibility: the shim uses ObjC runtime
method_setImplementationon a UIKit method (public selector, DEBUG-only). The alternative — running sims keyboardless — matches production but isn't durable in-repo. The shim was chosen for a durable green; trap documented indocs/testing.md.New test:
TipJarPresentationUITests(FR-1100-08 — tip jar reachable + presents from Settings; landscape load-bearing, red without the shim).Gates (iPad Pro 11-inch (M4), iPadOS 26.0, hardware keyboard connected): TipJarPresentationUITests 1/1 · PurchaseGateUITests 6/6 · SettingsUITests 4/4 · warm multi-class combo 11/11 · German sweep 74–76 3/3 — the three formerly uncapturable tip-jar screens are now captured and their German reviewed clean (no untranslated text, correct "du" register, no "lebenslang").
Fixes #42
https://claude.ai/code/session_01XWbnBdWdcjnCH5smD6X1Ai