Repository navigation
test: rebuild validation around essential product contracts - #244
Merged
Merged
Conversation
Contributor
|
pkg-pr-new preview for commit npx --yes https://pkg.pr.new/zcode-app-cli@e512e2eThis preview uses the selected commit. PR updates publish automatically after CI succeeds; kingsword09 can also request a preview with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuild the test baseline around observable product failures rather than preserving the existing suite by default, as requested.
bun run testrun all required layers sequentially; update the Node/OS subset and remove the obsolete Mountx CI gate.test/README.md. Manual scenarios and optional performance tools remain available.Trade-offs
This intentionally removes coverage, not just runtime cost. Visual/notification combinations, exhaustive Markdown streaming matrices, historical-runtime fixtures, platform-specific browser callbacks, and large stress workloads are no longer default gates. Passing the baseline does not prove those paths correct. New tests should cover a distinct observable risk that is not already represented.
Required runtime patch verification remains in synchronization and
check; the release pipeline still validates, packs, installs, and smoke-tests the actual artifact.Verification
Against the locked Desktop 3.17.1 / runtime 0.17.1 with Node v26.4.0:
bun run typecheck— passbun run test:unit— 37 passbun run test:tui— 14 passbun run test:runtime— 31 passbun run test:node— 15 passbun run test:runtime:compat— 11 pass (subset of runtime cases)bun run check— passbun run check:tui— real first-run/login/command/SIGHUP smoke passesbun scripts/check-package.ts— passbun run release:pack— tarball and isolated npm installation smoke passgit diff --checkand relative-import/script-entry-point checks — pass