Skip to content

test: rebuild validation around essential product contracts - #244

Merged
kingsword09 merged 1 commit into
mainfrom
test/minimal-contract-suite
Oct 31, 2026
Merged

kingsword09 merged 1 commit into
mainfrom
test/minimal-contract-suite

Conversation

@kingsword09

Copy link
Copy Markdown
Owner

Summary

Rebuild the test baseline around observable product failures rather than preserving the existing suite by default, as requested.

  • Reduce 152 test files to 29 files / 97 cases: 37 offline contracts, 14 PTY scenarios, 31 native-runtime cases, and 15 real-Node persistence cases.
  • Keep configuration/credential ownership, protocol errors/cancellation, queue/image ownership, single-use permissions, session/model recovery, streaming retries, SQLite rollback/concurrency, and release integrity.
  • Remove redundant implementation-string checks, rendering matrices, harness self-tests, long held-lock/process stress runs, duplicate automated smoke scripts, and unused fixtures.
  • Make bun run test run all required layers sequentially; update the Node/OS subset and remove the obsolete Mountx CI gate.
  • Document why every retained test file exists and explicitly list lost coverage in test/README.md. Manual scenarios and optional performance tools remain available.

Trade-offs

This intentionally removes coverage, not just runtime cost. Visual/notification combinations, exhaustive Markdown streaming matrices, historical-runtime fixtures, platform-specific browser callbacks, and large stress workloads are no longer default gates. Passing the baseline does not prove those paths correct. New tests should cover a distinct observable risk that is not already represented.

Required runtime patch verification remains in synchronization and check; the release pipeline still validates, packs, installs, and smoke-tests the actual artifact.

Verification

Against the locked Desktop 3.17.1 / runtime 0.17.1 with Node v26.4.0:

  • bun run typecheck — pass
  • bun run test:unit — 37 pass
  • bun run test:tui — 14 pass
  • bun run test:runtime — 31 pass
  • bun run test:node — 15 pass
  • bun run test:runtime:compat — 11 pass (subset of runtime cases)
  • bun run check — pass
  • bun run check:tui — real first-run/login/command/SIGHUP smoke passes
  • bun scripts/check-package.ts — pass
  • bun run release:pack — tarball and isolated npm installation smoke pass
  • git diff --check and relative-import/script-entry-point checks — pass

@github-actions

Copy link
Copy Markdown
Contributor

pkg-pr-new preview for commit e512e2e750c48d3674950f25f3dd098b7c5767b7.

npx --yes https://pkg.pr.new/zcode-app-cli@e512e2e

Full repository URL

This preview uses the selected commit. PR updates publish automatically after CI succeeds; kingsword09 can also request a preview with /pkg-pr-new.

Workflow logs

@kingsword09
kingsword09 merged commit 3a51841 into main Oct 31, 2026
5 checks passed
@kingsword09
kingsword09 deleted the test/minimal-contract-suite branch October 31, 2026 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant