Packages update - #35
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR releases version 1.11.1 with platform updates, iOS architectural changes to support Flutter implicit engines, Gradle plugin dependency upgrade, and refactored asset discovery in the levels provider using the native AssetManifest API. ChangesVersion 1.11.1 Release
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ios/Runner.xcodeproj/project.pbxproj (1)
498-498:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winUpdate
CURRENT_PROJECT_VERSIONto match the pubspec build number.The
CURRENT_PROJECT_VERSIONremains at35in all build configurations (Profile, Debug, Release), butpubspec.yamldeclares version1.11.1+36where36is the build number. This creates an inconsistency between the declared Flutter build number and the iOS project configuration.🔧 Suggested fix
Update
CURRENT_PROJECT_VERSIONto36in all three configurations (lines 498, 686, and 712):- CURRENT_PROJECT_VERSION = 35; + CURRENT_PROJECT_VERSION = 36;Also applies to: 686-686, 712-712
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ios/Runner.xcodeproj/project.pbxproj` at line 498, The iOS project file's CURRENT_PROJECT_VERSION is still set to 35 while pubspec.yaml declares version 1.11.1+36; update every occurrence of the CURRENT_PROJECT_VERSION assignment (the entries reading "CURRENT_PROJECT_VERSION = 35;" in the project.pbxproj) to the pubspec build number 36 so all build configurations (Debug, Profile, Release) match the Flutter build number.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@ios/Runner.xcodeproj/project.pbxproj`:
- Line 498: The iOS project file's CURRENT_PROJECT_VERSION is still set to 35
while pubspec.yaml declares version 1.11.1+36; update every occurrence of the
CURRENT_PROJECT_VERSION assignment (the entries reading "CURRENT_PROJECT_VERSION
= 35;" in the project.pbxproj) to the pubspec build number 36 so all build
configurations (Debug, Profile, Release) match the Flutter build number.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 00fa6d71-b9c0-46ac-982f-d684aabd6b7a
⛔ Files ignored due to path filters (2)
ios/Podfile.lockis excluded by!**/*.lockpubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
CHANGELOG.mdandroid/settings.gradle.ktsios/Flutter/AppFrameworkInfo.plistios/Runner.xcodeproj/project.pbxprojios/Runner/AppDelegate.swiftios/Runner/Info.plistlib/presentation/providers/levels_provider.dartpubspec.yaml
💤 Files with no reviewable changes (1)
- ios/Flutter/AppFrameworkInfo.plist
Checklist
Change type
Summary by CodeRabbit
Chores
Documentation