Skip to content

Packages update - #35

Merged
khlebobul merged 3 commits into
mainfrom
packages_update
May 15, 2026
Merged

khlebobul merged 3 commits into
mainfrom
packages_update

Conversation

@khlebobul

@khlebobul khlebobul commented May 15, 2026 •

Copy link
Copy Markdown
Owner

Checklist

Change type

  • bugfix
  • new lvl
  • new feature
  • other

Summary by CodeRabbit

  • Chores

    • Bumped version to 1.11.1
    • Updated package and platform dependencies
    • Updated iOS build configuration settings
  • Documentation

    • Added changelog entry for version 1.11.1

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 15, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@khlebobul has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 11 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 11359e97-982e-4744-be43-11c6e241f25e

📥 Commits

Reviewing files that changed from the base of the PR and between 2a457a7 and 134c13d.

📒 Files selected for processing (1)
  • ios/Runner.xcodeproj/project.pbxproj
📝 Walkthrough

Walkthrough

This PR releases version 1.11.1 with platform updates, iOS architectural changes to support Flutter implicit engines, Gradle plugin dependency upgrade, and refactored asset discovery in the levels provider using the native AssetManifest API.

Changes

Version 1.11.1 Release

Layer / File(s) Summary
Release version metadata and build configuration
CHANGELOG.md, pubspec.yaml, ios/Runner.xcodeproj/project.pbxproj
Changelog entry and package version incremented to 1.11.1; iOS build configuration MARKETING_VERSION updated across Profile, Debug, and Release targets.
iOS app configuration and implicit engine support
ios/Runner/AppDelegate.swift, ios/Runner/Info.plist, ios/Flutter/AppFrameworkInfo.plist
AppDelegate adopts FlutterImplicitEngineDelegate with plugin registration moved to implicit engine initialization; Info.plist extended with UIApplicationSceneManifest, CADisableMinimumFrameDurationOnPhone, and LSRequiresIPhoneOS settings; AppFrameworkInfo.plist MinimumOSVersion key removed.
Android Gradle plugin version update
android/settings.gradle.kts
com.android.application Gradle plugin version bumped from 8.7.3 to 8.9.1.
Asset loading refactor using AssetManifest API
lib/presentation/providers/levels_provider.dart
levelsProvider refactored to discover level assets via AssetManifest.loadFromAssetBundle and listAssets() instead of manual JSON file parsing; dart:convert import removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • khlebobul/pegma#5: Adds level asset files (level_21.json through level_30.json) whose discovery now depends on the refactored AssetManifest-based loading in levelsProvider.
  • khlebobul/pegma#30: Introduces level asset files (level_91.json through level_100.json) affected by the levelsProvider refactor to use AssetManifest for asset discovery.
  • khlebobul/pegma#11: Adds level assets (Levels 41–50) whose loading is governed by the refactored levelsProvider asset discovery mechanism.

Poem

🐰 Version 1.11.1 hops into place,
iOS engines race with implicit grace,
AssetManifest guides the level way,
Gradle climbs higher to greet the day!
Release complete, we celebrate with glee!

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description contains only the template checklist with 'other' marked, but lacks any substantive explanation of what packages were updated, why, or what the changes accomplish. Add detailed description explaining which packages were updated (e.g., Android Gradle plugin 8.7.3→8.9.1, Flutter version 1.11.0→1.11.1), the reasons for the updates, and any notable impacts or breaking changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Packages update' is vague and generic, using a non-descriptive term that does not clearly convey the specific nature of the changes beyond a general mention of package updates. Consider using a more specific title that captures the primary change, such as 'Update Android Gradle plugin and dependencies' or 'Upgrade to Flutter 3.x and update dependencies'.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch packages_update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
ios/Runner.xcodeproj/project.pbxproj (1)

498-498: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Update CURRENT_PROJECT_VERSION to match the pubspec build number.

The CURRENT_PROJECT_VERSION remains at 35 in all build configurations (Profile, Debug, Release), but pubspec.yaml declares version 1.11.1+36 where 36 is the build number. This creates an inconsistency between the declared Flutter build number and the iOS project configuration.

🔧 Suggested fix

Update CURRENT_PROJECT_VERSION to 36 in all three configurations (lines 498, 686, and 712):

-				CURRENT_PROJECT_VERSION = 35;
+				CURRENT_PROJECT_VERSION = 36;

Also applies to: 686-686, 712-712

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ios/Runner.xcodeproj/project.pbxproj` at line 498, The iOS project file's
CURRENT_PROJECT_VERSION is still set to 35 while pubspec.yaml declares version
1.11.1+36; update every occurrence of the CURRENT_PROJECT_VERSION assignment
(the entries reading "CURRENT_PROJECT_VERSION = 35;" in the project.pbxproj) to
the pubspec build number 36 so all build configurations (Debug, Profile,
Release) match the Flutter build number.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@ios/Runner.xcodeproj/project.pbxproj`:
- Line 498: The iOS project file's CURRENT_PROJECT_VERSION is still set to 35
while pubspec.yaml declares version 1.11.1+36; update every occurrence of the
CURRENT_PROJECT_VERSION assignment (the entries reading "CURRENT_PROJECT_VERSION
= 35;" in the project.pbxproj) to the pubspec build number 36 so all build
configurations (Debug, Profile, Release) match the Flutter build number.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 00fa6d71-b9c0-46ac-982f-d684aabd6b7a

📥 Commits

Reviewing files that changed from the base of the PR and between fe945c4 and 2a457a7.

⛔ Files ignored due to path filters (2)
  • ios/Podfile.lock is excluded by !**/*.lock
  • pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (8)
  • CHANGELOG.md
  • android/settings.gradle.kts
  • ios/Flutter/AppFrameworkInfo.plist
  • ios/Runner.xcodeproj/project.pbxproj
  • ios/Runner/AppDelegate.swift
  • ios/Runner/Info.plist
  • lib/presentation/providers/levels_provider.dart
  • pubspec.yaml
💤 Files with no reviewable changes (1)
  • ios/Flutter/AppFrameworkInfo.plist

@khlebobul khlebobul self-assigned this May 15, 2026
@khlebobul
khlebobul merged commit 0871353 into main May 15, 2026
2 checks passed
@khlebobul
khlebobul deleted the packages_update branch May 15, 2026 18:55
@coderabbitai coderabbitai Bot mentioned this pull request Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant