This repository was archived by the owner on Feb 1, 2020. It is now read-only.
Upgrade herrera-io/json dependency to 2.* version - #4
Open
tyranron wants to merge 1 commit into
Open
Conversation
Author
|
@kherge ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades
herrera-io/jsondependency version to2.*branch.Why?
With current sticking to
1.*version this project creates problems in dependencies resolving.For example (
composer.json):{ "require-dev": { "composer/composer": "~1.6", "phpdocumentor/phpdocumentor": "~2.9" } }These are the latest versions of Composer and phpDocumentor at the moment. But Composer won't resolve this, because
phpdocumentor/phpdocumentorrequires this project, and this project requiresherrera-io/jsonto be1.*, and that one requiresjustinrainbow/json-schemato be>=1.0,<2.0-dev. Which is incompatible with requirement ofcomposer/composer(justinrainbow/json-schemato be^3.0 || ^4.0 || ^5.0).The only possible way to resolve this at the moment is to downgrade
composer/composerto~1.3which considers1.*versions ofjustinrainbow/json-schema.Solution
Upgrading
herrera-io/jsonto2.*branch will require a^4.1ofjustinrainbow/json-schema, which will cause much less problems in transitive dependencies.