Skip to content

add option --ignore-stains#178

Merged
akhanf merged 3 commits into
mainfrom
ignore-stains
Jun 17, 2026
Merged

add option --ignore-stains#178
akhanf merged 3 commits into
mainfrom
ignore-stains

Conversation

@akhanf

@akhanf akhanf commented Jun 17, 2026

Copy link
Copy Markdown
Member

for dealing with inconsistent stains across subjects, can use this to ignore those
that are not common to all subjects

for dealing with inconsistent stains across subjects, can use this to    ignore those
that are not common to all subjects
@akhanf akhanf marked this pull request as ready for review June 17, 2026 07:42
@akhanf akhanf requested a review from Copilot June 17, 2026 07:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new workflow configuration/CLI option to tolerate inconsistent staining across subjects by allowing specific stains to be ignored when determining the dataset’s stain set, improving robustness of multi-subject runs when extra channels appear only in some subjects.

Changes:

  • Add ignore_stains CLI/config option and pass it into stain discovery in the main Snakefile.
  • Update get_stains_all_subjects() to optionally filter out ignored stains before enforcing cross-subject consistency.
  • Clarify help text for registration/segmentation downsampling level options.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
spimquant/workflow/Snakefile Passes configured ignored stains into stain discovery when sample_staining isn’t provided.
spimquant/workflow/rules/common.smk Extends stain-consistency logic to support filtering out ignored stains before comparing subjects.
spimquant/config/snakebids.yml Exposes new CLI option for ignored stains and refines downsampling help strings.

Comment thread spimquant/workflow/rules/common.smk Outdated
Comment thread spimquant/config/snakebids.yml
@akhanf akhanf merged commit c7e8c34 into main Jun 17, 2026
1 of 2 checks passed
@akhanf akhanf deleted the ignore-stains branch June 17, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants