add option --ignore-stains#178
Merged
Merged
Conversation
for dealing with inconsistent stains across subjects, can use this to ignore those that are not common to all subjects
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new workflow configuration/CLI option to tolerate inconsistent staining across subjects by allowing specific stains to be ignored when determining the dataset’s stain set, improving robustness of multi-subject runs when extra channels appear only in some subjects.
Changes:
- Add
ignore_stainsCLI/config option and pass it into stain discovery in the main Snakefile. - Update
get_stains_all_subjects()to optionally filter out ignored stains before enforcing cross-subject consistency. - Clarify help text for registration/segmentation downsampling level options.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
spimquant/workflow/Snakefile |
Passes configured ignored stains into stain discovery when sample_staining isn’t provided. |
spimquant/workflow/rules/common.smk |
Extends stain-consistency logic to support filtering out ignored stains before comparing subjects. |
spimquant/config/snakebids.yml |
Exposes new CLI option for ignored stains and refines downsampling help strings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for dealing with inconsistent stains across subjects, can use this to ignore those
that are not common to all subjects