Conversation
instead of ozx Also increase mem and resources for jobs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SPIMquant’s Snakemake workflow to write segmentation-derived datasets as directory-based OME-Zarr stores (rather than .ozx zipstores), with shared writer kwargs intended to enable chunking/sharding, and adjusts resource settings for several jobs. It also expands input discovery to include Imaris .ims files.
Changes:
- Switch many mask/dist outputs from
*.ozxto*.ome.zarrand mark most asdirectory(...)outputs in rules. - Standardize OME-Zarr writing in multiple scripts via
match_scale_factors_from=...and**config["zarrnii_out_kwargs"]. - Increase memory/resources for some rules and add
.imsas an allowed SPIM input extension.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| spimquant/workflow/scripts/vesselfm.py | Writes vessel masks to .ome.zarr with scale-factor matching and shared writer kwargs. |
| spimquant/workflow/scripts/threshold.py | Writes threshold masks to .ome.zarr with scale-factor matching and shared writer kwargs. |
| spimquant/workflow/scripts/skeletonize_vessels_mask.py | Writes skeleton masks to .ome.zarr with scale-factor matching and shared writer kwargs. |
| spimquant/workflow/scripts/signed_distance_transform.py | Writes SDT outputs to .ome.zarr with scale-factor matching and shared writer kwargs. |
| spimquant/workflow/scripts/n4_biasfield.py | Adds .ims-specific execution behavior for N4 processing. |
| spimquant/workflow/scripts/gmmthresh.py | Writes GMM threshold masks with shared writer kwargs. |
| spimquant/workflow/scripts/clean_segmentation.py | Writes cleaned masks with scale-factor matching and shared writer kwargs. |
| spimquant/workflow/rules/vessels.smk | Converts vessel intermediates to .ome.zarr directories and adjusts threads/mem/runtime. |
| spimquant/workflow/rules/templatereg.smk | Updates some template-registration outputs to .ome.zarr and increases memory for selected rules. |
| spimquant/workflow/rules/segmentation.smk | Converts segmentation outputs to .ome.zarr directories. |
| spimquant/workflow/rules/regionprops.smk | Updates inputs to consume .ome.zarr masks/dist outputs. |
| spimquant/workflow/rules/qc.smk | Updates QC rules to consume .ome.zarr masks. |
| spimquant/workflow/rules/patches.smk | Updates patch generation inputs to consume .ome.zarr masks. |
| spimquant/workflow/rules/heatmaps.smk | Increases memory for heatmap generation rules. |
| spimquant/workflow/rules/fieldfrac.smk | Updates inputs to consume .ome.zarr masks and increases memory for mapping step. |
| spimquant/workflow/rules/common.smk | Minor formatting-only change. |
| spimquant/config/snakebids.yml | Adds .ims input extension support and introduces zarrnii_out_kwargs for writer configuration. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Added additional parameters to the to_ome_zarr function call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of ozx
Also increase mem and resources for jobs