Repository navigation
fix(diagnostics): expose translation failure details - #217
Merged
Merged
Conversation
Preserve original provider and translation exceptions through Job execution, persistence, and the failure UI. Show the message directly, with expandable codes and context and readable multiline diagnostics. Add shared UTC millisecond timestamps to server, access, and translation logs, and load the configuration from Docker, development, and E2E startup commands. Existing generic Job errors remain unchanged until a new attempt records its failure reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Translation failures now retain the original exception message from PySubtrans through the Job API and persistence layer. Failed Job details show that message directly, including provider errors, instead of replacing it with
Translation failed.Impact
The existing
error.messagefield stores the failure reason; no database migration is required. Error details already reduced to a generic message cannot be recovered from existing Job records. A new translation attempt records its actual failure reason.Custom Uvicorn startup commands can enable the shared log format with
--log-config cueweaver/logging.json.