pyproject: pin deps to versions buildable on python 3.10 through 3.14 - #107
Open
mentonin wants to merge 1 commit into
Open
pyproject: pin deps to versions buildable on python 3.10 through 3.14#107mentonin wants to merge 1 commit into
mentonin wants to merge 1 commit into
Conversation
Signed-off-by: Luiz Georg <luiz.georg@profusion.mobi>
|
this will needlessly blow up downstream consumers like https://gitlab.com/cki-project/pipeline-definition/-/blob/main/requirements-python.in?ref_type=heads - eg kcidb-io works just fine with a jsonschema < 4.18; the upstream pyproject.toml is not the right place to enforce downstream constraints (like python314 compat); if a certain dependency does not work in your downstream env, enforce a working dep version there |
Author
|
That makes sense. What about the optional-dependencies.dev pinning? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add minimum version pins to packages that do not build on supported python versions.
Tests
I tested that these are the minimum versions that build under python 3.10 through 3.14 using
uv sync --resolution lowest-direct. I did not test any runtime behavior on these versions. I also did not test that transitive dependencies build on these python versions.jsonschema>=4.26.0was an exception. It is not the earliest buildable jsonschema version, but it fixes a similar issue for itsrdps-pydependency for python 3.14, so using it avoids at least one transitive dependency issue for python 3.14 compatibility.