Bump kernel-go-sdk to v0.64.0 and migrate to paginated List#179
Closed
Sayan- wants to merge 1 commit into
Closed
Conversation
The SDK bump is a prerequisite for the telemetry opt-in CLI work, which needs the new telemetry category params. v0.64 changes the resource List methods to return paginated results and renames the proxy config union fields, so migrate every consumer to compile against the new API. - List now takes a *ListParams and returns *pagination.OffsetPagination[T]; update the proxies, browser pools, credential providers, and extensions command interfaces, call sites, and fakes to read page.Items. - Rename proxy create config union fields/types (OfDatacenter, OfIsp, OfResidential, OfMobile, OfCustom) and BrowserPoolUpdateParams.Size is now an optional int64. - The mobile proxy config dropped carrier/zip/asn and the proxy check/get/ list responses dropped carrier, so remove the now-dead --carrier flag and carrier display rows. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Created a monitoring plan for this PR. What this PR does: Updates the Kernel CLI to use pagination-wrapped list responses from the new Go SDK, and removes mobile proxy carrier targeting from the Intended effect:
Risks:
Status updates will be posted automatically on this PR as monitoring progresses. |
Contributor
Author
|
Superseded by #177, which already absorbs this exact SDK-bump migration (paginated List for proxies/browser-pools/credential-providers/extensions, proxy config union rename, --carrier removal) as its first commit f7bdb1e — and goes further with --limit/--offset flags and the browser name/tags feature. Closing in favor of #177. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prerequisite for the telemetry opt-in CLI change (
sayan/kernel-1342-switch-to-opt-in-for-categories), which needs the telemetry category params introduced in the newer SDK. Bumpingkernel-go-sdkfrom v0.58.0 to v0.64.0 pulls in unrelated breaking API changes that have to be absorbed first.The bump breaks more than proxies (Go's build had been stopping at the proxies dependency, masking the rest). Every
Listconsumer and the proxy config unions needed migrating:List:Listnow takes a*ListParamsand returns*pagination.OffsetPagination[T]instead of*[]T. Migrated the local service interfaces, call sites, and test fakes forproxies,browser_pools,credential_providers, andextensionsto passListParams{}and readpage.Items.OfDatacenter,OfIsp,OfResidential,OfMobile,OfCustom/ProxyNewParamsConfigDatacenter, etc.).BrowserPoolUpdateParams.Sizeis now an optionalint64(kernel.Int(...)).carrier(alsozip/asnon mobile request config, andcarrieron the check/get/list responses). Removed the now-dead--carrierflag and the carrier display rows.Behavior notes
--carrieris removed because the API no longer accepts or returns it.--zip/--asnremain (still valid for residential); they're silently ignored for mobile now, matching the API.listcommands still do a singleListcall and render the returned page, preserving the prior single-call behavior (no auto-paging change). If we wantlistto page through everything, that's a separate follow-up.Test plan
go build ./...go test ./...(all green)go vet ./...,gofmt -l,go mod tidycleankernel proxies list/create/get/check,kernel browser-pools list,kernel extensions list,kernel credential-providers listagainst prodMade with Cursor
Note
Medium Risk
Wide CLI/SDK contract changes (list pagination, proxy create payloads, removed
--carrier) can surprise users and truncate results if the API default page size is smaller than a full account list; core auth paths are untouched.Overview
Bumps
kernel-go-sdkfrom v0.58.0 to v0.64.0 so follow-up work (e.g. telemetry category params) can land on the newer client.Paginated
List: Service interfaces and handlers for browser pools, credential providers, extensions, and proxies now callListwith empty*ListParamsand readpage.Itemsfrom*pagination.OffsetPagination[T]instead of*[]T. Test fakes were updated the same way. List commands still perform a single list request (no multi-page iteration).Proxy SDK shape:
proxies createuses renamed config union fields (OfDatacenter,OfIsp,OfResidential,OfMobile,OfCustom) and matching config types.Other SDK fixes:
browser-pools updatesets pool size viakernel.Int(...).Mobile proxy CLI: Removes
--carrierand carrier display on get/check/list; mobile create no longer sends zip/asn/carrier on the mobile config. Mobile list/get display emphasizes city where carrier used to appear.Reviewed by Cursor Bugbot for commit a02df96. Bugbot is set up for automated code reviews on this repo. Configure here.