Skip to content

Bump kernel-go-sdk to v0.64.0 and migrate to paginated List#179

Closed
Sayan- wants to merge 1 commit into
mainfrom
sayan/kernel-1342-bump-sdk-fix-proxies
Closed

Bump kernel-go-sdk to v0.64.0 and migrate to paginated List#179
Sayan- wants to merge 1 commit into
mainfrom
sayan/kernel-1342-bump-sdk-fix-proxies

Conversation

@Sayan-

@Sayan- Sayan- commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Prerequisite for the telemetry opt-in CLI change (sayan/kernel-1342-switch-to-opt-in-for-categories), which needs the telemetry category params introduced in the newer SDK. Bumping kernel-go-sdk from v0.58.0 to v0.64.0 pulls in unrelated breaking API changes that have to be absorbed first.

The bump breaks more than proxies (Go's build had been stopping at the proxies dependency, masking the rest). Every List consumer and the proxy config unions needed migrating:

  • Paginated List: List now takes a *ListParams and returns *pagination.OffsetPagination[T] instead of *[]T. Migrated the local service interfaces, call sites, and test fakes for proxies, browser_pools, credential_providers, and extensions to pass ListParams{} and read page.Items.
  • Proxy create config union: renamed union fields/types to the new names (OfDatacenter, OfIsp, OfResidential, OfMobile, OfCustom / ProxyNewParamsConfigDatacenter, etc.).
  • BrowserPoolUpdateParams.Size is now an optional int64 (kernel.Int(...)).
  • Mobile proxy + responses dropped carrier (also zip/asn on mobile request config, and carrier on the check/get/list responses). Removed the now-dead --carrier flag and the carrier display rows.

Behavior notes

  • --carrier is removed because the API no longer accepts or returns it. --zip/--asn remain (still valid for residential); they're silently ignored for mobile now, matching the API.
  • list commands still do a single List call and render the returned page, preserving the prior single-call behavior (no auto-paging change). If we want list to page through everything, that's a separate follow-up.

Test plan

  • go build ./...
  • go test ./... (all green)
  • go vet ./..., gofmt -l, go mod tidy clean
  • Smoke test kernel proxies list/create/get/check, kernel browser-pools list, kernel extensions list, kernel credential-providers list against prod

Made with Cursor


Note

Medium Risk
Wide CLI/SDK contract changes (list pagination, proxy create payloads, removed --carrier) can surprise users and truncate results if the API default page size is smaller than a full account list; core auth paths are untouched.

Overview
Bumps kernel-go-sdk from v0.58.0 to v0.64.0 so follow-up work (e.g. telemetry category params) can land on the newer client.

Paginated List: Service interfaces and handlers for browser pools, credential providers, extensions, and proxies now call List with empty *ListParams and read page.Items from *pagination.OffsetPagination[T] instead of *[]T. Test fakes were updated the same way. List commands still perform a single list request (no multi-page iteration).

Proxy SDK shape: proxies create uses renamed config union fields (OfDatacenter, OfIsp, OfResidential, OfMobile, OfCustom) and matching config types.

Other SDK fixes: browser-pools update sets pool size via kernel.Int(...).

Mobile proxy CLI: Removes --carrier and carrier display on get/check/list; mobile create no longer sends zip/asn/carrier on the mobile config. Mobile list/get display emphasizes city where carrier used to appear.

Reviewed by Cursor Bugbot for commit a02df96. Bugbot is set up for automated code reviews on this repo. Configure here.

The SDK bump is a prerequisite for the telemetry opt-in CLI work, which
needs the new telemetry category params. v0.64 changes the resource
List methods to return paginated results and renames the proxy config
union fields, so migrate every consumer to compile against the new API.

- List now takes a *ListParams and returns *pagination.OffsetPagination[T];
  update the proxies, browser pools, credential providers, and extensions
  command interfaces, call sites, and fakes to read page.Items.
- Rename proxy create config union fields/types (OfDatacenter, OfIsp,
  OfResidential, OfMobile, OfCustom) and BrowserPoolUpdateParams.Size is
  now an optional int64.
- The mobile proxy config dropped carrier/zip/asn and the proxy check/get/
  list responses dropped carrier, so remove the now-dead --carrier flag
  and carrier display rows.

Co-authored-by: Cursor <cursoragent@cursor.com>
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgolang/​github.com/​kernel/​kernel-go-sdk@​v0.58.0 ⏵ v0.64.072 +1100100100100

View full report

@firetiger-agent

Copy link
Copy Markdown

Created a monitoring plan for this PR.

What this PR does: Updates the Kernel CLI to use pagination-wrapped list responses from the new Go SDK, and removes mobile proxy carrier targeting from the proxies create command.

Intended effect:

  • GetProxies server errors: baseline 0/hr; confirmed if it stays 0 after users run proxies list with the new CLI
  • GetBrowserPools / GetCredentialProviders / GetExtensions list errors: baseline 0/hr; confirmed if all list commands return valid output (no panics, no unexpected empty results)
  • UpdateBrowserPoolsByIdOrName 4xx: baseline 0 client errors (at 300/hr volume); confirmed if no new 4xx appear after the size-param wrapper change

Risks:

  • Pagination params break list APIGetProxies or GetBrowserPools 4xx rises from 0 (empty params struct may send unexpected query args the API rejects)
  • Mobile create breaks existing automationPostProxies 4xx rises >5pp above current ~16% baseline; or user reports "unknown flag: --carrier"
  • Browser pool size update regressionUpdateBrowserPoolsByIdOrName 4xx rises from 0; kernel.Int() wrapper may serialize differently than bare int

Status updates will be posted automatically on this PR as monitoring progresses.

View monitor

@Sayan-

Sayan- commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #177, which already absorbs this exact SDK-bump migration (paginated List for proxies/browser-pools/credential-providers/extensions, proxy config union rename, --carrier removal) as its first commit f7bdb1e — and goes further with --limit/--offset flags and the browser name/tags feature. Closing in favor of #177.

@Sayan- Sayan- closed this Jun 9, 2026
@Sayan- Sayan- deleted the sayan/kernel-1342-bump-sdk-fix-proxies branch June 9, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant